fix: sync foundry.lock forge-std rev with submodule#3789
Merged
Conversation
The forge-std rev in foundry.lock was pinned to f61e4dd1 which lacks signEd25519. The git submodule already points to e72518ef which includes it. The Argo invariant-tests workflow clones without --recursive, so forge auto-installs from foundry.lock and hits a compile error on vm.signEd25519() in ValidatorConfigV2.t.sol. Update the lockfile to match the submodule. Amp-Thread-ID: https://ampcode.com/threads/T-019de2a8-040f-712b-8dc2-9b659a8d8dd1 Co-authored-by: Amp <amp@ampcode.com>
decofe
requested review from
0xKitsune,
dankrad,
danrobinson and
legion2002
as code owners
Contributor
📊 Tempo Precompiles CoverageprecompilesCoverage: 5620/7657 lines (73.40%) File details
contractsCoverage: 1/226 lines (0.44%) File details
Total: 5621/7883 lines (71.31%) |
emmajam
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Argo
invariant-testsworkflow has been failing with exit code 1 (compile error) since ~Apr 28. The workflow clones without--recursive, solib/forge-std/is empty and forge auto-installs fromfoundry.lock.foundry.lockpinnedforge-stdtof61e4dd1which lackssignEd25519, while the git submodule already points toe72518efwhich has it. This causes:in
ValidatorConfigV2.t.sol.GHA
specs.ymlpasses because it clones withsubmodules: recursive(uses the submodule version directly).Fix
Update
tips/verify/foundry.lockto pinforge-stdtoe72518ef87be67df939a70b0ff1cb349e92b6dde, matching the submodule.Context
Ordertype #419) resolved the earlier revm mismatch (exit 101) but did not address this second issue.