Skip to content

ci: pin foundry SHA for invariant tests#3768

Merged
emmajam merged 1 commit into
mainfrom
ejh/pin-foundry-sha
Apr 30, 2026
Merged

ci: pin foundry SHA for invariant tests#3768
emmajam merged 1 commit into
mainfrom
ejh/pin-foundry-sha

Conversation

@emmajam
Copy link
Copy Markdown
Member

@emmajam emmajam commented Apr 30, 2026

Pins the foundry checkout in specs.yml to be874c9f instead of tracking master.

The branch (mablr/alloy_bump_without_op) ships an alloy 2.0.4 bump with OP stack support stripped, which unblocks the invariant-test build after #3761 moved tempo to alloy 2.0.4 / alloy-evm 0.34.

Verified locally: forge test against tips/verify runs clean — 482 passed, 0 failed, 6 skipped.

Pins the foundry checkout in specs.yml to a specific SHA on
mablr/alloy_bump_without_op instead of tracking master. The branch
ships an alloy 2.0.4 bump with OP stack support stripped, which
unblocks tempo's reth bump (#3761) without requiring an alloy-evm
0.34 port of alloy-op-evm/op-reth.

Amp-Thread-ID: https://ampcode.com/threads/T-019ddd67-4b2a-757e-88b3-3c395d034b32
Co-authored-by: Amp <amp@ampcode.com>
@emmajam emmajam requested review from 0xrusowsky and klkvr April 30, 2026 08:35
@emmajam emmajam enabled auto-merge April 30, 2026 08:42
@emmajam emmajam added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit 4839a8b Apr 30, 2026
33 checks passed
@emmajam emmajam deleted the ejh/pin-foundry-sha branch April 30, 2026 08:51
Thegreatsura pushed a commit to Thegreatsura/tempo that referenced this pull request May 2, 2026
## Problem

The Argo `invariant-tests` workflow has been failing with exit code 1
(compile error) since ~Apr 28. The workflow clones without
`--recursive`, so `lib/forge-std/` is empty and forge auto-installs from
`foundry.lock`.

`foundry.lock` pinned `forge-std` to `f61e4dd1` which **lacks
`signEd25519`**, while the git submodule already points to `e72518ef`
which **has it**. This causes:

```
Error (9582): Member "signEd25519" not found or not visible after argument-dependent lookup in contract Vm.
```

in `ValidatorConfigV2.t.sol`.

GHA `specs.yml` passes because it clones with `submodules: recursive`
(uses the submodule version directly).

## Fix

Update `tips/verify/foundry.lock` to pin `forge-std` to
`e72518ef87be67df939a70b0ff1cb349e92b6dde`, matching the submodule.

## Context

- The foundry-branch pin fix (PR tempoxyz#3768 / workflows tempoxyz#419) resolved the
earlier revm mismatch (exit 101) but did not address this second issue.
- Slack thread:
https://tempoxyz.slack.com/archives/C0A6PD3BQ3F/p1777601759314299

Co-authored-by: Centaur AI <ai@centaur.local>
Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants