You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think this should drop the enabled fields in favor of breaking the default behavior for a cleaner design such that passing null actually means disabled (instead of default behavior) and push the default behavior up to the lang SDK layers, just like in temporalio/sdk-python#1501. @Sushisource, what do you think?
Thank you for bringing the issue to our attention and proactively providing a fix.
I ended up reimplementing the change in #1267 without the enabled field and aligned it with the behavior of the other SDKs. I'll close out this PR at this time since it has been superseded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added
TemporalCoreClientDnsLoadBalancingOptionsto the C bridge, so that users of the C bridge can set these options how they needWhy?
Users of the C bridge want to be able to change the dns load balancing options
Checklist
#1250
Consumed this change in the .NET SDK: temporalio/sdk-dotnet#676
Verified all tests pass (both
cargo testin this repository, anddotnet testin the dotnet-sdk`)