Conversation
Contributor
|
Thank you for bringing the issue to our attention and proactively providing a fix. I ended up reimplementing the change in #689 without the enabled field and aligned it with the behavior of the other SDKs. I'll close out this PR at this time since it has been superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
temporalio/sdk-rust#1250
DNS load balancing was introduced in temporalio/sdk-rust#1212, and it defaults to enabled for users of the C bridge.
These options should be exposed through the C bridge, so that users of the C bridge, such as .NET SDK users, can configure DNS load balancing.
Why?
.NET users want to be able to change the DNS load balancing options of the gRPC client
Checklist
Closes
How was this tested:
I ran the tests locally
If the Rust side change is merged, will need to update the submodule to point to the upstream repo instead of my fork: temporalio/sdk-rust#1250