Skip to content

Move Step step action reference test to container_validation_test.go. #8779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Move Step step action reference test to container_validation_test.go. #8779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions pkg/apis/pipeline/v1/container_validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,43 @@ func TestStepValidateErrorWithArtifactsRef(t *testing.T) {
}
}

func TestStepWithStepActionReferenceValidate(t *testing.T) {
tests := []struct {
name string
Step v1.Step
}{{
name: "valid stepAction ref",
Step: v1.Step{
Name: "mystep",
Ref: &v1.Ref{
Name: "stepAction",
},
},
}, {
name: "valid use of params with Ref",
Step: v1.Step{
Ref: &v1.Ref{
Name: "stepAction",
},
Params: v1.Params{{
Name: "param",
}},
},
}}
for _, st := range tests {
t.Run(st.name, func(t *testing.T) {
ctx := config.ToContext(t.Context(), &config.Config{
FeatureFlags: &config.FeatureFlags{
EnableStepActions: true,
},
})
if err := st.Step.Validate(ctx); err != nil {
t.Errorf("Step.Validate() = %v", err)
}
})
}
}

func TestSidecarValidate(t *testing.T) {
tests := []struct {
name string
Expand Down
Loading