Move Step step action reference test to container_validation_test.go.
#8779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/L
25 tasks
|
The following is the coverage report on the affected files.
|
tekton-robot
added
the
needs-rebase
twoGiants
changed the title
Step step action reference test to container_validation_test.go. 🚧 Step step action reference test to container_validation_test.go.
twoGiants
force-pushed
the
issue-8700-move-step-step-action-reference-test
branch
from
7a0c347 to
c37fbe4
Compare
tekton-robot
added
size/M
tekton-robot
removed
the
do-not-merge/work-in-progress
|
/ok-to-test |
tekton-robot
added
the
ok-to-test
|
/retest |
tekton-robot
added
the
approved
|
/retest |
|
/lgtm |
tekton-robot
added
lgtm
twoGiants
force-pushed
the
issue-8700-move-step-step-action-reference-test
branch
from
c37fbe4 to
ed79ff5
Compare
tekton-robot
added
needs-rebase
Now that `Step` implements the `Validatable` interface the tests for the `Step` validation are moved from `task_validation_test.go` to `container_validation_test.go`. The following tests is moved and renamed: - `TestTaskSpecStepActionReferenceValidate` - `TestStepWithStepActionReferenceValidate` Issue tektoncd#8700. Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants
force-pushed
the
issue-8700-move-step-step-action-reference-test
branch
from
ed79ff5 to
38f7dd6
Compare
tekton-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Now that
Stepimplements theValidatableinterface the tests for theStepvalidation are moved fromtask_validation_test.gotocontainer_validation_test.go.The following tests is moved and renamed:
TestTaskSpecStepActionReferenceValidateTestStepWithStepActionReferenceValidateThis PR is one of a series to migrate the tests in small batches so that they are easier to review.
More details are in issue #8700. Closes #8700.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes