Skip to content

Fix typo in SW_CAPABLE_PLATFORM block#22

Merged
teemuatlut merged 1 commit intoteemuatlut:masterfrom
thinkyhead:fix_compile_error
Sep 6, 2018
Merged

Fix typo in SW_CAPABLE_PLATFORM block#22
teemuatlut merged 1 commit intoteemuatlut:masterfrom
thinkyhead:fix_compile_error

Conversation

@thinkyhead
Copy link
Copy Markdown
Contributor

@thinkyhead thinkyhead commented Sep 6, 2018 •
edited
Loading

  • The constructor for SW serial was being included accidentally.
  • The uses_sw_serial variable can be static constexpr without SW_CAPABLE_PLATFORM.

@thinkyhead thinkyhead mentioned this pull request Sep 6, 2018
Merged
@teemuatlut
Copy link
Copy Markdown
Owner

teemuatlut commented Sep 6, 2018

Looks good. Is this ready to be merged in?

@thinkyhead
Copy link
Copy Markdown
Contributor Author

thinkyhead commented Sep 6, 2018

I think so. Do you want to bump the version too?

@teemuatlut
Copy link
Copy Markdown
Owner

teemuatlut commented Sep 6, 2018

I'll do it in a separate commit.

@teemuatlut teemuatlut merged commit aefa60b into teemuatlut:master Sep 6, 2018
@thinkyhead thinkyhead deleted the fix_compile_error branch September 6, 2018 06:46
@teemuatlut
Copy link
Copy Markdown
Owner

teemuatlut commented Sep 7, 2018

v0.2.4...v0.2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thinkyhead @teemuatlut