Skip to content

[2.0.x] Update to TMC2208Stepper 0.2.5#11714

Merged
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead:bf2_misc_fixes_aug_6
Sep 9, 2018
Merged

[2.0.x] Update to TMC2208Stepper 0.2.5#11714
thinkyhead merged 1 commit intoMarlinFirmware:bugfix-2.0.xfrom
thinkyhead:bf2_misc_fixes_aug_6

Conversation

@thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Sep 4, 2018

The TCM2208Stepper library has been updated to 0.2.5, with support for software serial on the LPC1768 platform.

@thinkyhead thinkyhead force-pushed the bf2_misc_fixes_aug_6 branch 2 times, most recently from e8e38e6 to 2ce4572 Compare September 4, 2018 05:38
@thinkyhead
Copy link
Member Author

@teemuatlut — Are there other changes I need to make? Getting these errors.

@thinkyhead thinkyhead changed the title Try out TMC2208Stepper 0.2.4 [2.0.x] Update to TMC2208Stepper 0.2.4 Sep 4, 2018
@teemuatlut
Copy link
Member

You're testing TMC2208 with SW serial on platforms that don't support it.
Either drop TMC2208 tests on them, or set the test to use HW serial.

I'd also suggest this to be added to SanityCheck.h

/**
 * TMC2208 software UART is only supported on AVR and LPC1768
 */
#if HAS_DRIVER(TMC2208) && !(defined(__AVR__) || defined(TARGET_LPC1768)) && !( \
       defined(X_HARDWARE_SERIAL ) \
    || defined(X2_HARDWARE_SERIAL) \
    || defined(Y_HARDWARE_SERIAL ) \
    || defined(Y2_HARDWARE_SERIAL) \
    || defined(Z_HARDWARE_SERIAL ) \
    || defined(Z2_HARDWARE_SERIAL) \
    || defined(E0_HARDWARE_SERIAL) \
    || defined(E1_HARDWARE_SERIAL) \
    || defined(E2_HARDWARE_SERIAL) \
    || defined(E3_HARDWARE_SERIAL) \
    || defined(E4_HARDWARE_SERIAL) )
  #error "TMC2208 Software Serial is supported only on AVR and LPC1768 platforms."
#endif

@thinkyhead
Copy link
Member Author

thinkyhead commented Sep 5, 2018

You're testing TMC2208 with SW serial on platforms that don't support it.

I didn't alter the Travis CI tests for any platforms, but only specified that 0.2.4 should be used (also for LPC1768) in the .ini file. So Travis CI should be doing exactly the same tests for 0.2.4 as it was doing for 0.2.3. The errors simply don't occur with the previous version of the library. Did the default behavior change in some way?

I'd also suggest this to be added to SanityCheck.h

That was already done.

@teemuatlut
Copy link
Member

v0.2.4 hides the SW serial constructor of the library when used with platforms that are not supported with a SW serial library.

@thinkyhead
Copy link
Member Author

thinkyhead commented Sep 6, 2018

v0.2.4 hides the SW serial constructor of the library when used with platforms that are not supported with a SW serial library.

Almost…

teemuatlut/TMC2208Stepper#22

@thinkyhead thinkyhead changed the title [2.0.x] Update to TMC2208Stepper 0.2.4 [2.0.x] Update to TMC2208Stepper 0.2.5 Sep 6, 2018
@thinkyhead thinkyhead removed the request for review from teemuatlut September 6, 2018 06:55
@thinkyhead
Copy link
Member Author

Once the library version is updated to 0.2.5 I will restart the Travis CI tests and expect them to pass.

@thinkyhead thinkyhead merged commit eafd623 into MarlinFirmware:bugfix-2.0.x Sep 9, 2018
@thinkyhead thinkyhead deleted the bf2_misc_fixes_aug_6 branch September 9, 2018 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants