-
-
Notifications
You must be signed in to change notification settings - Fork 29
feat: CSS-only usage, HTML components, and more #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… further validate)
🦋 Changeset detectedLatest commit: 0a4743e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
commit: |
…e to inconsistent source order
…leBand (ex. punchcard chart)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #160
Resolves #259
Resolves #408
Resolves #512
Resolves #544
Resolves #590
Resolves #594
Resolves #595
Resolves #640
CSS-only usage
@layer basefor primitives (ex. Line) and@layer componentsfor higher components (ex. Axis) to fix CSS ordering / specificity:where(...)for all declarations to keep specificity to0to allow easy overriding without worrying about CSS ordering (ex. shadcn-svelte, app.css)@layer base, components, utilities;in theirapp.cssto guarantee layer order@import layerchart/styles.cssor similar. also looking to add@import layerchart/skeleton.css/ etcTODO
extractLayerProps()when applying classesAxis{@const ruleProps = extractLayerProps(rule, 'lc-axis-rule')} <Rule x={placement === 'left' ? '$left' : placement === 'right' ? '$right' : placement === 'angle'} y={placement === 'top' ? '$top' : placement === 'bottom' ? '$bottom' : placement === 'radius'} {motion} {...ruleProps} class={cls('stroke-surface-content/50 bg-surface-content/50', classes.rule, ruleProps?.class)} />--color, or--stroke-color/--fill-colorfor many components to simplify Svg/Canvas vs Html usage (stroke vs border/outline, fill vs background)<line stroke="red">) over built-in class:where(.lc-line):not([stroke]) { ... }, but what about upstream classes/attributes--stroke-color) instead of classes should allow the application to only happen in primitives by defaultfoo === 'object'to usegetObjectOrNull()utilfoo === 'function' ? foo(item) : footo useresolveMaybeFn()utilsurface-*colorsopacity-*absolute/ positioningw-*,h-*:global()to a style sheet, or handle differently?cls()(use built in clsx) unless normalizing multiple propstransition-opacityfor all primitive (using opacity prop instead ofopacity-10class for fading out unhighlighted series)? Wait tilsettings()is supported?