Skip to content

Model the remote artifact broker as optional #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 1 commit into from
Sep 22, 2026
Merged

Model the remote artifact broker as optional #1103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions src/immutable_artifact_distribution.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ impl ArtifactProducerProvider {
}
}

/// Accepted origin provenance. A local, peer, or R2 copy preserves this exact producer record.
/// Accepted origin provenance. A local, peer, or optional remote-broker copy preserves this exact producer record.
#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
pub struct ArtifactProducerProvenance {
pub provider: ArtifactProducerProvider,
Expand Down Expand Up @@ -188,7 +188,7 @@ impl ArtifactProducerProvenance {
}
}

/// One immutable object identity shared unchanged by local, peer, R2, and provider copies.
/// One immutable object identity shared unchanged by local, peer, optional remote-broker, and provider copies.
#[derive(Debug, Clone, PartialEq, Eq, Serialize)]
pub struct ImmutableArtifactObjectIdentity {
pub schema_version: u8,
Expand Down Expand Up @@ -351,8 +351,24 @@ pub enum ImmutableArtifactSourceClass {
}

impl ImmutableArtifactSourceClass {
/// Source order for a co-located persistent fleet that does not need a remote broker.
///
/// GitHub Actions remains the canonical provider fallback. Skipping R2 changes only
/// acceleration topology; it does not change object identity or validity.
#[must_use]
pub const fn same_site_first_lookup_order() -> [Self; 4] {
[
Self::NodeLocal,
Self::TrustedPeer,
Self::GitHubActions,
Self::Rebuild,
]
}

/// Source order when an optional private R2 broker is configured for remote distribution,
/// off-site resilience, or retention.
#[must_use]
pub const fn lookup_order() -> [Self; 5] {
pub const fn with_private_r2_lookup_order() -> [Self; 5] {
[
Self::NodeLocal,
Self::TrustedPeer,
Expand Down Expand Up @@ -543,9 +559,18 @@ mod tests {
}

#[test]
fn source_order_keeps_every_transport_advisory() {
fn source_order_keeps_remote_broker_optional() {
assert_eq!(
ImmutableArtifactSourceClass::same_site_first_lookup_order(),
[
ImmutableArtifactSourceClass::NodeLocal,
ImmutableArtifactSourceClass::TrustedPeer,
ImmutableArtifactSourceClass::GitHubActions,
ImmutableArtifactSourceClass::Rebuild,
]
);
assert_eq!(
ImmutableArtifactSourceClass::lookup_order(),
ImmutableArtifactSourceClass::with_private_r2_lookup_order(),
[
ImmutableArtifactSourceClass::NodeLocal,
ImmutableArtifactSourceClass::TrustedPeer,
Expand Down