Repository navigation
Model the remote artifact broker as optional - #1103
Merged
Merged
Conversation
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1068.
Summary
Make the immutable artifact distribution contract represent the topology decision in #1068 explicitly:
node local -> trusted peer -> GitHub Actions -> rebuild;node local -> trusted peer -> private R2 -> GitHub Actions -> rebuild.R2 remains a source class for source-specific observations, but broker presence is no longer baked into the only lookup-order API.
Contract
The change keeps exact object identity, producer provenance, compatibility, and validation authority unchanged. It only separates source-policy configuration from product correctness.
ImmutableArtifactSourceClassnow exposes:same_site_first_lookup_order();with_private_r2_lookup_order().The regression test asserts both orders and keeps GitHub/rebuild fallback present in either policy.
Why
Persistent co-located CMUX nodes should use local disk and same-site peers as the ordinary acceleration path. A remote broker earns activation for off-site distribution, resilience, retention, or measured residual GitHub cost; it is not required for correctness.
Verification
Exact head
5a218d6a7d6e673e4c37e7b62aa4c5411485d05eis green in hostedVerifyandLinux acceptance;Cultist advisoryalso completed successfully.No physical fleet mutation or credential/configuration change is included.