Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(aspects): resolve (installed) aspects in workspace from its node_modules #6901

Merged
merged 31 commits into from
Mar 2, 2023
Merged

change(aspects): resolve (installed) aspects in workspace from its node_modules #6901

merged 31 commits into from
Mar 2, 2023

Commits on Jan 10, 2023

  1. extract all load/resolve aspects from workspace to its own class

    @GiladShoham
    GiladShoham committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    170ea51 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. implement new aspect resolution from installed aspects

    @GiladShoham
    GiladShoham committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    8afd5a5 View commit details
    Browse the repository at this point in the history

  2. remove any scope related stuff in workspace aspect loader

    @GiladShoham
    GiladShoham committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    3e09d86 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. install root aspects on bit install 

    add option to not throw during resolve aspects
    @GiladShoham
    GiladShoham committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    77ff1fd View commit details
    Browse the repository at this point in the history

  2. improve warning outputs

    @GiladShoham
    GiladShoham committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    4744466 View commit details
    Browse the repository at this point in the history

  3. moving bit use functionality to WorkspaceAspectsLoader 

    Refactor creation of WorkspaceAspectsLoader instance
    @GiladShoham
    GiladShoham committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    8bc15e1 View commit details
    Browse the repository at this point in the history

  4. run install on bit use command if it's scope aspect

    @GiladShoham
    GiladShoham committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    84216f9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/teambit/bit into ws-resol… 

    …ve-aspects-node_modules

# Conflicts:
#	scopes/workspace/workspace/workspace.ts
    @GiladShoham
    GiladShoham committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    bf791aa View commit details
    Browse the repository at this point in the history

  6. make func private

    @GiladShoham
    GiladShoham committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    85786dd View commit details
    Browse the repository at this point in the history

  7. load component extensions from capsules

    @GiladShoham
    GiladShoham committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    2b56418 View commit details
    Browse the repository at this point in the history

  8. linting

    @GiladShoham
    GiladShoham committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    d76c1b9 View commit details
    Browse the repository at this point in the history

  9. fix tests

    @GiladShoham
    GiladShoham committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    d4b9ea0 View commit details
    Browse the repository at this point in the history

  10. extract scope aspects functions to scope aspect loader

    @GiladShoham
    GiladShoham committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    116f748 View commit details
    Browse the repository at this point in the history

  11. linting

    @GiladShoham
    GiladShoham committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    98ac16b View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2023

  1. load component aspects from scope safely (including handle missing de… 

    …ps during load)
    @GiladShoham
    GiladShoham committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    f2e9052 View commit details
    Browse the repository at this point in the history

  2. move filter aspect defs to aspects loader

    @GiladShoham
    GiladShoham committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    e1745fe View commit details
    Browse the repository at this point in the history

  3. pass package manager root dir to load aspects

    @GiladShoham
    GiladShoham committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    fc3955d View commit details
    Browse the repository at this point in the history

  4. linting

    @GiladShoham
    GiladShoham committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    c8a6659 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/teambit/bit into ws-resol… 

    …ve-aspects-node_modules

# Conflicts:
#	scopes/workspace/workspace/workspace.ts
    @GiladShoham
    GiladShoham committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    efd288d View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. improve error handling

    @GiladShoham
    GiladShoham committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    cc2e99b View commit details
    Browse the repository at this point in the history

  2. fixes

    @GiladShoham
    GiladShoham committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    82a0ba2 View commit details
    Browse the repository at this point in the history

  3. fixes

    @GiladShoham
    GiladShoham committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    8c6cfb0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into ws-resolve-aspects-node_modules

    @GiladShoham
    GiladShoham authored Jan 16, 2023
    Configuration menu
    Copy the full SHA
    b4c8981 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into ws-resolve-aspects-node_modules

    @GiladShoham
    GiladShoham authored Jan 16, 2023
    Configuration menu
    Copy the full SHA
    5f93bf3 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Merge branch 'master' into ws-resolve-aspects-node_modules 

    # Conflicts:
#	scopes/workspace/install/install.main.runtime.ts
#	scopes/workspace/workspace/workspace.ts
    @GiladShoham
    GiladShoham committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    3988dee View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Merge branch 'master' into ws-resolve-aspects-node_modules 

    # Conflicts:
#	scopes/workspace/workspace/workspace.ts
    @GiladShoham
    GiladShoham committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    ce5c5e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Merge branch 'master' into ws-resolve-aspects-node_modules 

    # Conflicts:
#	scopes/workspace/workspace/aspects-merger.ts
#	scopes/workspace/workspace/workspace.main.runtime.ts
#	scopes/workspace/workspace/workspace.provider.ts
#	scopes/workspace/workspace/workspace.ts
    @GiladShoham
    GiladShoham committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    391f9a3 View commit details
    Browse the repository at this point in the history

  2. linting

    @GiladShoham
    GiladShoham committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    5257007 View commit details
    Browse the repository at this point in the history

  3. always load envs from scope

    @GiladShoham
    GiladShoham committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    d943a2b View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. hard coded resolve non workspace aspects from the scope capsules (tem… 

    …porarily)
    @GiladShoham
    GiladShoham committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    5383eb1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/teambit/bit into ws-resol… 

    …ve-aspects-node_modules

# Conflicts:
#	scopes/workspace/workspace/workspace.ts
    @GiladShoham
    GiladShoham committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    556f030 View commit details
    Browse the repository at this point in the history