Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(aspects): resolve (installed) aspects in workspace from its node_modules #6901

Merged
merged 31 commits into from
Mar 2, 2023
Merged

change(aspects): resolve (installed) aspects in workspace from its node_modules #6901

merged 31 commits into from
Mar 2, 2023

Conversation

GiladShoham
Copy link
Member

@GiladShoham GiladShoham commented Jan 10, 2023 •
edited
Loading

Proposed Changes

  • Install used aspects in the workspace during bit install
  • (DISABLED) When working in a workspace - resolve aspects which are not part of the workspace (bitmap) from node_modules.
    (instead of from a scope aspects capsules that we used to use until now)
    Right now this feature is disabled hardcoded as it causes some issues. we will enable it in a separate PR.
  • refactor any load/resolve aspects logic from the main workspace class to its own class (WorkspaceAspectsLoader)
  • refactor any load/resolve aspects logic from the main scope class to its own class (ScopeAspectsLoader)

@GiladShoham
extract all load/resolve aspects from workspace to its own class
170ea51
@GiladShoham
implement new aspect resolution from installed aspects
8afd5a5
@GiladShoham
remove any scope related stuff in workspace aspect loader
3e09d86
@GiladShoham
install root aspects on bit install
77ff1fd 
add option to not throw during resolve aspects
@GiladShoham
improve warning outputs
4744466
@GiladShoham
moving bit use functionality to WorkspaceAspectsLoader
8bc15e1 
Refactor creation of WorkspaceAspectsLoader instance
@GiladShoham
run install on bit use command if it's scope aspect
84216f9
@GiladShoham
Merge branch 'master' of https://github.com/teambit/bit into ws-resol…
bf791aa 
…ve-aspects-node_modules

# Conflicts:
#	scopes/workspace/workspace/workspace.ts
@GiladShoham
make func private
85786dd
@GiladShoham
load component extensions from capsules
2b56418
@GiladShoham
linting
d76c1b9
@GiladShoham
fix tests
d4b9ea0
@GiladShoham
extract scope aspects functions to scope aspect loader
116f748
@GiladShoham
linting
98ac16b
@GiladShoham
load component aspects from scope safely (including handle missing de…
f2e9052 
…ps during load)
@GiladShoham
move filter aspect defs to aspects loader
e1745fe
@GiladShoham
pass package manager root dir to load aspects
fc3955d
@GiladShoham
linting
c8a6659
@GiladShoham
Merge branch 'master' of https://github.com/teambit/bit into ws-resol…
efd288d 
…ve-aspects-node_modules

# Conflicts:
#	scopes/workspace/workspace/workspace.ts
@GiladShoham
improve error handling
cc2e99b
@GiladShoham
fixes
82a0ba2
@GiladShoham
fixes
8c6cfb0
@GiladShoham
Merge branch 'master' into ws-resolve-aspects-node_modules
b4c8981
@GiladShoham
Merge branch 'master' into ws-resolve-aspects-node_modules
5f93bf3
@GiladShoham
Merge branch 'master' into ws-resolve-aspects-node_modules
3988dee 
# Conflicts:
#	scopes/workspace/install/install.main.runtime.ts
#	scopes/workspace/workspace/workspace.ts
@GiladShoham
Merge branch 'master' into ws-resolve-aspects-node_modules
ce5c5e6 
# Conflicts:
#	scopes/workspace/workspace/workspace.ts
@GiladShoham
Merge branch 'master' into ws-resolve-aspects-node_modules
391f9a3 
# Conflicts:
#	scopes/workspace/workspace/aspects-merger.ts
#	scopes/workspace/workspace/workspace.main.runtime.ts
#	scopes/workspace/workspace/workspace.provider.ts
#	scopes/workspace/workspace/workspace.ts
@GiladShoham
linting
5257007
@GiladShoham
always load envs from scope
d943a2b
@GiladShoham
hard coded resolve non workspace aspects from the scope capsules (tem…
5383eb1 
…porarily)
@GiladShoham GiladShoham changed the title resolve (installed) aspects in workspace from its node_modules change(aspects): resolve (installed) aspects in workspace from its node_modules Mar 2, 2023
@GiladShoham
Merge branch 'master' of https://github.com/teambit/bit into ws-resol…
556f030 
…ve-aspects-node_modules

# Conflicts:
#	scopes/workspace/workspace/workspace.ts
@GiladShoham GiladShoham marked this pull request as ready for review March 2, 2023 12:44
@GiladShoham GiladShoham merged commit 3c1dcf7 into master Mar 2, 2023
@GiladShoham GiladShoham deleted the ws-resolve-aspects-node_modules branch March 2, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guysaar223 guysaar223 guysaar223 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiladShoham @guysaar223