New unicode styles #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added UnicodeDoubleWalled and UnicodeDoubleFloored with accompanying unit tests.
|
Looks great @oisinmcl. At work at the mo, but will give it a proper test this evening. Thanks for your contribution! |
|
Thanks again @oisinmcl. I've checked this properly now and it's perfect! 💯 Merging now. Feel free to see if there are any other open issues you'd like to tackle. 😄 |
tdwright
approved these changes
Dec 18, 2018
|
Hi Tom, No worries, it was my first contribution to an open source project. I hope to keep it up and tackle more difficult issues in the feature. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64
New unicode styles UnicodeDoubleWalled and UnicodeDoubleFloored with accompanying unit tests.