Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New unicode styles #64

Closed
tdwright opened this issue Nov 21, 2018 · 3 comments
Closed

New unicode styles #64

tdwright opened this issue Nov 21, 2018 · 3 comments

Comments

@tdwright
Copy link
Owner

Doubled walled

╓──╥──╖
║  ║  ║ 
╟──╫──╢
║  ║  ║ 
╙──╨──╜ 

Double floored

╒══╤══╕
│  │  │
╞══╪══╡
│  │  │
╘══╧══╛ 
@oisinmcl
Copy link

Hi,
Is this issue being worked on? I would like to start contributing and I feel this would be a good first contribution.

Thanks
Oisin

@tdwright tdwright added this to the Version 2.0 milestone Dec 16, 2018
@tdwright
Copy link
Owner Author

Hi @oisinmcl! 👋

It's all yours if you want it. And you're just in time for the version 2.0 milestone.

Have a look at the contributor guidelines and in particular the section on testing. For new styles, we tend to need one test per style.

Let me know if I can help at all. Otherwise I shall eagerly anticipate a pull request!

Tom 😄

@oisinmcl
Copy link

Hi Tom,

OK I will start this today. I had a read over the guidelines and will contact if I need help.

Looking forward to contributing.

Thanks
Oisin

@ghost ghost removed the backlog label Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants