Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for %WrapForValidIteratorPrototype%.return() from Iterator Helpers Proposal #4214

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Add tests for %WrapForValidIteratorPrototype%.return() from Iterator Helpers Proposal #4214

merged 2 commits into from
Sep 13, 2024

Commits on Sep 13, 2024

  1. Add tests for %WrapForValidIteratorPrototype%.return()

    @sosukesuzuki @ptomato
    sosukesuzuki authored and ptomato committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    73a33a9 View commit details
    Browse the repository at this point in the history

  2. Address review 

    - Remove unused `flags
- Do not use `deepEqual.js`
- Assert `return` never got when `this` value is invalid
- Use `TemporalHelpers` to observer get / call
    @sosukesuzuki @ptomato
    sosukesuzuki authored and ptomato committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    64326e8 View commit details
    Browse the repository at this point in the history