Add tests for %WrapForValidIteratorPrototype%.return() from Iterator Helpers Proposal
#4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
changed the title
%WrapForValidIteratorPrototype%.return()%WrapForValidIteratorPrototype%.return() from Iterator Helpers Proposal
sosukesuzuki
force-pushed
the
add-test-for-WrapForValidIteratorPrototype-return
branch
from
f797595
to
f617443
Compare
ptomato
requested changes
Sep 12, 2024
test/built-ins/Iterator/from/get-return-method-when-call-return.js
Outdated
Show resolved
Hide resolved
test/built-ins/Iterator/from/return-method-calls-base-return-method.js
Outdated
Show resolved
Hide resolved
test/built-ins/Iterator/from/return-method-returns-iterator-result.js
Outdated
Show resolved
Hide resolved
test/built-ins/Iterator/from/get-return-method-when-call-return.js
Outdated
Show resolved
Hide resolved
test/built-ins/Iterator/from/return-method-throws-for-invalid-this.js
Outdated
Show resolved
Hide resolved
|
@ptomato Thank you for your review! I've addressed all of your comments. |
- Remove unused `flags - Do not use `deepEqual.js` - Assert `return` never got when `this` value is invalid - Use `TemporalHelpers` to observer get / call
ptomato
force-pushed
the
add-test-for-WrapForValidIteratorPrototype-return
branch
from
21273ca
to
64326e8
Compare
sosukesuzuki
deleted the
add-test-for-WrapForValidIteratorPrototype-return
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing
Iterator.fromin WebKit1, I noticed that nearly all test262 test cases pass without implementing%WrapForValidIteratorPrototype%.return()2.Although this method is not particularly complex, I believe there should be minimal tests for it.
This PR adds tests for
%WrapForValidIteratorPrototype%.return().Footnotes
https://github.com/WebKit/WebKit/pull/32741 ↩
https://tc39.es/proposal-iterator-helpers/#sec-wrapforvaliditeratorprototype.return ↩