Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup asyncHelpers #4091

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Cleanup asyncHelpers #4091

merged 8 commits into from
Aug 1, 2024
+51 −66

Commits on Aug 1, 2024

  1. CONTRIBUTING.md: Improve asyncHelpers documentation 

    * Only mention `$DONE` after `asyncTest`.
* Document that `asyncTest` is not intended to be called multiple times per file.
    @gibson042
    gibson042 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    8ca5bdd View commit details
    Browse the repository at this point in the history

  2. harness/asyncHelpers.js: Add doc comments

    @gibson042
    gibson042 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1b34a1c View commit details
    Browse the repository at this point in the history

  3. harness/asyncHelpers.js: Refactor assert.throwsAsync to fail fast

    @gibson042
    gibson042 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b22b500 View commit details
    Browse the repository at this point in the history

  4. harness/asyncHelpers.js: Isolate assert.throwsAsync failure conditions

    @gibson042
    gibson042 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0631e21 View commit details
    Browse the repository at this point in the history

  5. harness/asyncHelpers.js: Fix an assert.throwsAsync failure message typo

    @gibson042
    gibson042 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b87eaf9 View commit details
    Browse the repository at this point in the history

  6. harness/asyncHelpers.js: Clean up assert.throwsAsync failure messages 

    * Remove mention of an "inner" promise/thenable.
    @gibson042
    gibson042 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0b61e98 View commit details
    Browse the repository at this point in the history

  7. harness/asyncHelpers.js: Reduce the size of assert.throwsAsync

    @gibson042
    gibson042 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    fa3d024 View commit details
    Browse the repository at this point in the history

  8. harness/asyncHelpers.js: Further reduce the size of assert.throwsAsync

    @gibson042
    gibson042 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f83c1b9 View commit details
    Browse the repository at this point in the history