Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup asyncHelpers #4091

Merged
merged 8 commits into from
Aug 1, 2024

Conversation

gibson042
Copy link
Contributor

CONTRIBUTING.md

  • Only mention $DONE after asyncTest.
  • Document that asyncTest is not intended to be called multiple times per file.

harness/asyncHelpers.js

  • Add doc comments.
  • Refactor assert.throwsAsync to fail fast and isolate error conditions.
  • Clean up assert.throwsAsync failure messages (remove mention of an "inner" promise/thenable).
  • Reduce the size of assert.throwsAsync for better comprehensibility in one screenful.

@gibson042 gibson042 requested a review from a team as a code owner May 19, 2024 17:57
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clear split into commits, that was very helpful when reviewing.

The only thing I have reservations about is renaming innerThenable to p in the final commit — I don't think that improves the readability. Everything else looks good.

@gibson042 gibson042 force-pushed the gibson-2024-05-cleanup-asynchelpers branch from 487d89e to f83c1b9 Compare August 1, 2024 16:10
@gibson042 gibson042 merged commit 7a91671 into tc39:main Aug 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants