Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect tests landed in PR3890 #4051

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fix incorrect tests landed in PR3890 #4051

merged 1 commit into from
Apr 11, 2024

Conversation

FrankYFTang
Copy link
Contributor

#3890

include incorrect tests which lack fo some definition and incorrect expectation.

@ben-allen @anba @Ms2ger

@FrankYFTang FrankYFTang requested a review from a team as a code owner April 11, 2024 00:24
@anba
Copy link
Contributor

anba commented Apr 11, 2024

LGTM. The changes match 6c005f5 from #3983.

@ben-allen
Copy link
Contributor

LGTM -- thanks for the catch

Ms2ger
Ms2ger approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and apologies for not catching this in review.

@Ms2ger Ms2ger merged commit b37b6f3 into tc39:main Apr 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FrankYFTang @anba @ben-allen @Ms2ger