Update to reflect normative change in formatting when Intl.DurationFormat's fractionalDigits option is undefined #3890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
requested changes
Aug 8, 2023
Ms2ger
approved these changes
Oct 3, 2023
Ms2ger
force-pushed
the
fractionaldigits-undefined
branch
from
54176af
to
a329844
Compare
|
This PR is wrong between the end of the comment. |
|
This test is wrong |
FrankYFTang
added a commit
to FrankYFTang/test262
that referenced
this pull request
Apr 11, 2024
|
Also fixed by #3983 |
Ms2ger
pushed a commit
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tc39/proposal-intl-duration-format#144 recently changed the behaviour of Intl.DurationFormat when the number of fractional digits (i.e. sub-second values) is left undefined. prototype/format/style-digital-fractionalDigits-undefined.js tests for this case, prototype/format/style-digital-fractionalDigits.js provides additional test coverage for fractional digits in general.