Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for "Limit valid values for DurationFormats to match upcoming limits in Temporal" #3988

Closed
wants to merge 7 commits into from

Commits on Jan 9, 2024

  1. Sync partitionDurationFormatPattern with latest spec draft

    Sync `partitionDurationFormatPattern` with the latest spec draft and
    change it to use an `Intl.DurationFormat` object as the input, so it's
    easier to compare it against the spec text and because it allows to test
    more inputs.
    
    Includes the fixes for:
    - tc39/proposal-intl-duration-format#183
    - tc39/proposal-intl-duration-format#184
    anba committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    648fef8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c005f5 View commit details
    Browse the repository at this point in the history
  3. Use formatDurationFormatPattern for "/numeric-hour-with-zero-minutes-…

    …and-non-zero-seconds"
    
    The changes from the first commit allow to use
    `formatDurationFormatPattern` for this test.
    anba committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    6b4499e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cd6b789 View commit details
    Browse the repository at this point in the history
  5. Update numeric-hour-with-zero-minutes-and-non-zero-seconds for new de…

    …fault display of sub-hours units
    
    Numeric "minute" and "seconds" units now default to "always" display, so we have
    to add an additional test to cover when "auto" display is used. Additionally add
    more inputs to cover all possible test combinations.
    anba committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    3dbb467 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    099d65e View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Update tests for "Limit valid values for DurationFormats to match upc…

    …oming limits in Temporal"
    
    Update tests for
    <tc39/proposal-intl-duration-format#173>.
    anba committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    282dc3d View commit details
    Browse the repository at this point in the history