Fix and simplify "displayRequired" computation in PartitionDurationFormatPattern #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `durationFormat.[[HoursStyle]]` is "numeric" or "2-digit" and either `durationFormat.[[HoursDisplay]]` is "always" or `duration.[[Hours]]` is non-zero, then the previous loop iteration set `needSeparator` to `true`. Drive-by change: Use booleans for `displayRequired`.
To determine if the minutes field should always be formatted, we need to inspect all sub-minutes duration fields.
`needSeparator` only needed to be reset to output `"2, 01"`.
anba
added a commit
to anba/test262
that referenced
this pull request
Jan 9, 2024
Sync `partitionDurationFormatPattern` with the latest spec draft and change it to use an `Intl.DurationFormat` object as the input, so it's easier to compare it against the spec text and because it allows to test more inputs. Includes the fixes for: - tc39/proposal-intl-duration-format#183 - tc39/proposal-intl-duration-format#184
ryzokuken
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
LGTM overall, is this normative or a bugfix? I lean towards the latter but would love to hear your thoughts @anba @sffc @FrankYFTang
|
yes, I think this PR is better. |
|
lgtm! note that these errors are (unless I'm mistaken) also fixed in #188, which is waiting for review/re-review |
ben-allen
approved these changes
Apr 17, 2024
Ms2ger
pushed a commit
to anba/test262
that referenced
this pull request
Apr 23, 2024
Sync `partitionDurationFormatPattern` with the latest spec draft and change it to use an `Intl.DurationFormat` object as the input, so it's easier to compare it against the spec text and because it allows to test more inputs. Includes the fixes for: - tc39/proposal-intl-duration-format#183 - tc39/proposal-intl-duration-format#184
Ms2ger
pushed a commit
to tc39/test262
that referenced
this pull request
Apr 23, 2024
Sync `partitionDurationFormatPattern` with the latest spec draft and change it to use an `Intl.DurationFormat` object as the input, so it's easier to compare it against the spec text and because it allows to test more inputs. Includes the fixes for: - tc39/proposal-intl-duration-format#183 - tc39/proposal-intl-duration-format#184
|
closed as fixed by #188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
durationFormat.[[SecondsValue]]should beduration.[[Seconds]]Simplications:
displayRequiredto a boolean.durationFormat.[[HoursStyle]],durationFormat.[[HoursDisplay]], andduration.[[Hours]]don't have to be inspected, instead simply testing ifneedSeparatoristrueis sufficient.needSeparatordoesn't need to be reset. This step was only present for compatibility with previous revisions to output strings like1, 03for{hours: 1, seconds: 3}(see hours: "numeric" w/ 0 in minutes and non 0 in seconds cause strange output. #170).