-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate resizable buffer tests out of staging #3888
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bce4496
Migrate resizable buffer tests out of staging
syg 01cc908
Merge branch 'main' into graduate-rab-gsab
ioannad 9b52b7d
Delete test/built-ins/TypedArray/prototype/slice/coerced-start-grow.js
ioannad 35aff5a
Merge branch 'main' into graduate-rab-gsab
ioannad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
30 changes: 30 additions & 0 deletions
30
test/built-ins/ArrayBuffer/prototype/resize/coerced-new-length-detach.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
// Copyright 2023 the V8 project authors. All rights reserved. | ||
// This code is governed by the BSD license found in the LICENSE file. | ||
|
||
/*--- | ||
esid: sec-arraybuffer.prototype.resize | ||
description: > | ||
ArrayBuffer.p.resize has one detach check after argument coercion | ||
includes: [detachArrayBuffer.js] | ||
features: [resizable-arraybuffer] | ||
---*/ | ||
|
||
{ | ||
const rab = new ArrayBuffer(64, { maxByteLength: 1024 }); | ||
let called = false; | ||
assert.throws(TypeError, () => rab.resize({ valueOf() { | ||
$DETACHBUFFER(rab); | ||
called = true; | ||
}})); | ||
assert(called); | ||
} | ||
|
||
{ | ||
const rab = new ArrayBuffer(64, { maxByteLength: 1024 }); | ||
$DETACHBUFFER(rab); | ||
let called = false; | ||
assert.throws(TypeError, () => rab.resize({ valueOf() { | ||
called = true; | ||
}})); | ||
assert(called); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file was added by PR #4174 under the name |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 0 additions & 92 deletions
92
test/staging/ArrayBuffer/resizable/access-out-of-bounds-typed-array.js
This file was deleted.
Oops, something went wrong.
109 changes: 0 additions & 109 deletions
109
test/staging/ArrayBuffer/resizable/array-fill-parameter-conversion-resizes.js
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only new test file in this PR that has not been added by the series of "RAB" PRs referencing this PR.
LGTM!