Migrate resizable buffer tests out of staging #3888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review ping. |
@syg A few of us have started to review this over the past weeks but unfortunately it's quite large. We're trying to find a way for someone to commit time to it and failing that will otherwise try to split it up between maintainers. Thanks for your patience. |
|
@ptomato Thanks. If it helps, this PR just splits up existing tests in staging, following the principle that each test262 tests for a single "behavior". |
|
Another ping. |
ioannad
added a commit
to ioannad/test262
that referenced
this pull request
Mar 26, 2024
…ray buffers. These are the parts of the code in RAB staging tests that are heavily repeated. In order to somewhat compact the migration of RAB staging tests (see PR tc39#3888).
ioannad
added a commit
to ioannad/test262
that referenced
this pull request
Mar 26, 2024
…ray buffers. These are the parts of the code in RAB staging tests that are heavily repeated. In order to somewhat compact the migration of RAB staging tests (see PR tc39#3888).
|
I created PR #4030 which has a helper file with a lot of the duplicated code from the files in this PR. During the maintainers meeting yesterday we decided that when PR #4030 is merged, I will be removing the duplicated code from the test files of this PR, and will be adding the cleaned up tests to separate smaller PRs, split by method. The goal is to make it easier to split up the review load. When each smaller PR gets merged we plan to rebase this PR so that it keeps getting smaller and we make sure we didn't forget anything. |
ljharb
pushed a commit
to ioannad/test262
that referenced
this pull request
Apr 30, 2024
…ray buffers. These are the parts of the code in RAB staging tests that are heavily repeated. In order to somewhat compact the migration of RAB staging tests (see PR tc39#3888).
ptomato
pushed a commit
that referenced
this pull request
Apr 30, 2024
Collection of helper constants and functions for testing resizable array buffers. These are the parts of the code in RAB staging tests that are heavily repeated. In order to somewhat compact the migration of RAB staging tests (see PR #3888).
ioannad
added a commit
to ioannad/test262
that referenced
this pull request
May 3, 2024
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
ioannad
added a commit
to ioannad/test262
that referenced
this pull request
May 3, 2024
of TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
ioannad
added a commit
to ioannad/test262
that referenced
this pull request
May 3, 2024
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
ioannad
added a commit
to ioannad/test262
that referenced
this pull request
May 3, 2024
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
ioannad
added a commit
to ioannad/test262
that referenced
this pull request
May 3, 2024
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
ioannad
added a commit
to ioannad/test262
that referenced
this pull request
May 3, 2024
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
ptomato
pushed a commit
that referenced
this pull request
May 8, 2024
* RAB: Integrate staging tests for .at method of Array.prototype and TypedArray.prototype This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
ptomato
pushed a commit
to ioannad/test262
that referenced
this pull request
May 8, 2024
of TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
ptomato
pushed a commit
that referenced
this pull request
May 8, 2024
* RAB: Integrate staging tests for .byteLength method of TypedArray.prototype This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
ioannad
added a commit
to ioannad/test262
that referenced
this pull request
Jun 24, 2024
tc39#4074 (review) Adds forgotten tests from tc39#3888
ptomato
pushed a commit
to ioannad/test262
that referenced
this pull request
Jun 26, 2024
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
This was referenced Jul 30, 2024
ptomato
pushed a commit
to ioannad/test262
that referenced
this pull request
Aug 5, 2024
ptomato
pushed a commit
that referenced
this pull request
Aug 5, 2024
* Import relevant files from #3888 * Removing parts in resizableArrayBufferUtils.js and adding it in includes, and renaming helper function.
ptomato
pushed a commit
to ioannad/test262
that referenced
this pull request
Aug 6, 2024
ptomato
pushed a commit
that referenced
this pull request
Aug 6, 2024
* Import relevant files from #3888 * Removing parts in resizableArrayBufferUtils.js and adding it in includes, while applying review changes from PRs for previously tested methods. * Renamed test files * Some minor documentation fixes and removing onlyStrict flag
ptomato
pushed a commit
to ioannad/test262
that referenced
this pull request
Aug 6, 2024
ptomato
pushed a commit
that referenced
this pull request
Aug 6, 2024
* Import relevant files from #3888 * Removing parts in resizableArrayBufferUtils.js and adding it in includes, while applying review changes from PRs for previously tested methods. * Removes unnecessary .from calls, as suggested in previous PR review comment: #4138 (comment)
ptomato
pushed a commit
to ioannad/test262
that referenced
this pull request
Aug 9, 2024
ptomato
pushed a commit
that referenced
this pull request
Aug 9, 2024
* Import relevant files from #3888 * Removing parts in resizableArrayBufferUtils.js and adding it in includes, while applying review changes from PRs for previously tested methods. * Address review comments.
ptomato
pushed a commit
to ioannad/test262
that referenced
this pull request
Aug 13, 2024
ptomato
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Import relevant files from #3888 * Removing parts in resizableArrayBufferUtils.js and adding it in includes, while applying review changes from PRs for previously tested methods. * Add coerced-start-shrink test for Array.p.slice * Renames files to add more tests for the end argument of .slice. * Tests for the 'end' argument of .slice and test file for Array.p.slice parallel to TypedArray.p.slice resizable-buffer.js
ptomato
pushed a commit
to ioannad/test262
that referenced
this pull request
Aug 14, 2024
ptomato
pushed a commit
that referenced
this pull request
Aug 14, 2024
* Import relevant files from #3888 * Removing parts in resizableArrayBufferUtils.js and adding it in includes, while applying review changes from PRs for previously tested methods. * Apply suggestions from code review * Address review: get implementation dependent toLocaleString separator. * Apply suggestions from code review
ptomato
pushed a commit
to ioannad/test262
that referenced
this pull request
Aug 15, 2024
ptomato
pushed a commit
that referenced
this pull request
Aug 15, 2024
* Import relevant files from #3888 * Adds resizableArrayBufferUtils.js to includes and removes its content from each test * renamed tests to indicate the end argument is tested too * Adds more tests for the 'end' argument of .subarray
ptomato
force-pushed
the
graduate-rab-gsab
branch
from
375f54b
to
bce4496
Compare
|
Rebased after merging all of the tests belonging to Array and TypedArray methods. |
ioannad
added a commit
to ioannad/test262
that referenced
this pull request
Aug 15, 2024
Ms2ger
pushed a commit
to ioannad/test262
that referenced
this pull request
Aug 27, 2024
Ms2ger
pushed a commit
to ioannad/test262
that referenced
this pull request
Aug 27, 2024
ioannad
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
This file was added by PR #4174 under the name test/built-ins/TypedArray/prototype/slice/coerced-start-end-grow.js, so it should be removed from here.
There was a problem hiding this comment.
This is the only new test file in this PR that has not been added by the series of "RAB" PRs referencing this PR.
LGTM!
Removed file previously added by PR tc39#4174
|
@ptomato: I deleted the duplicate test file, so this is now ready to be merged. |
Ms2ger
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all resizable buffer tests out of staging into the main test suite. Tests that multiple similar methods at once are split up to to multiple files to be consistent with the existing directory structure.
No tests have been removed.
test/built-ins/ArrayBuffer/prototype/resize/coerced-new-length-detach.jsis a new test that tests the normative detach timing change from the July 2023 TC39.