typeCoercion.js includes BigInt literal without "features: [BigInt]" #1252
Comments
|
Harness files are not required to contain any frontmatter, and for that we don't expect runners to parse harness files for features tags, those should be used on the tests files including them, as the one you mentioned has the features tag for BigInt, already. The features.yml includes features requirements for includes. Our built-in linter tool will confirm every test including typeCoercion.js has the features BigInt included. We might need to revisit this, but for now this is the best we have. |
leobalter
pushed a commit
that referenced
this issue
Oct 3, 2017
typeCoercion.js is included in several tests which are not marked as `features: [BigInt]`. Since BigInt is new feature, we should not make the above unrelated tests failed due to lack of BigInt syntax support. Close #1252.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
New
typeCoercion.jsincludes BigInt literal like0n. And it causes some test failures liketest262/test/built-ins/String/prototype/indexOf/position-tointeger.jsif VM does not support BigInt literal.But
test262/test/built-ins/String/prototype/indexOf/position-tointeger.jsis essentially unrelated to BigInt.Since BigInt is new feature, and since
typeCoercion.jsis not marked withfeatures: [BigInt],BigInt(0)is better way.The text was updated successfully, but these errors were encountered: