Skip to content

Commit

Permalink
Do not use BigInt literal without features: [BigInt] (#1253)
Browse files Browse the repository at this point in the history
typeCoercion.js is included in several tests which are not marked as `features: [BigInt]`.
Since BigInt is new feature, we should not make the above unrelated tests failed due to
lack of BigInt syntax support.

Close #1252.
  • Loading branch information
Constellation authored and leobalter committed Oct 3, 2017
1 parent 5f338a3 commit ba891c7
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions harness/typeCoercion.js
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,8 @@ function testCoercibleToBigIntZero(test) {
testPrimitiveWrappers(value, "number", test);
}

testCoercibleToBigIntFromBigInt(0n, test);
testPrimitiveValue(-0n);
testCoercibleToBigIntFromBigInt(BigInt(0), test);
testPrimitiveValue(-BigInt(0));
testPrimitiveValue("-0");
testPrimitiveValue(false);
testPrimitiveValue("");
Expand All @@ -351,7 +351,7 @@ function testCoercibleToBigIntOne(test) {
testPrimitiveWrappers(value, "number", test);
}

testCoercibleToBigIntFromBigInt(1n, test);
testCoercibleToBigIntFromBigInt(BigInt(1), test);
testPrimitiveValue(true);

// toString() returns "1"
Expand Down

0 comments on commit ba891c7

Please sign in to comment.