Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/host and trim #74

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Fixes/host and trim #74

merged 2 commits into from
Nov 10, 2021

Conversation

tarkah
Copy link
Collaborator

@tarkah tarkah commented Nov 9, 2021

This PR makes 2 changes:

  1. Uses the new --host and host flags for lazystream to better setup a host override. The variable hostOverride, if set, will update the host used by lazystream and the hosts file update in the docker container. This provides a more robust implementation over feat: make lazy stream host name configurable #72
  2. Make trim_xmltv default to no. I don't think having it as a default is good practice, as it's a breaking change and I don't believe reliable at all w/ xTeVe.

@tarkah tarkah force-pushed the fixes/host-and-trim branch from 91a14e9 to f5f3d9d Compare November 9, 2021 03:27
Copy link
Owner

@taylorbourne taylorbourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯
I think the trim works in my setup because of the way I generate/merge m3u playlists, so I'm on board with whatever works better across the board. Part of the reason I jammed the hostname change in was because I wasn't sure how I felt about the actual host living in the repo. But I guess.. it ain't my server.

Thanks again dude

@taylorbourne taylorbourne merged commit 190cc66 into master Nov 10, 2021
@taylorbourne taylorbourne deleted the fixes/host-and-trim branch November 11, 2021 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants