Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make lazy stream host name configurable #72

Merged
merged 10 commits into from
Nov 4, 2021
Merged

Conversation

taylorbourne
Copy link
Owner

@taylorbourne taylorbourne commented Nov 3, 2021

so this is going to be a breaking change (which is funny since things are already broken) but everyone will need to set the new variable...

Makes more sense this way anyway. I have a pretty solid fork of Xteve going so maybe we can bake some of this stuff in in the future. For now, this'll do.

@taylorbourne taylorbourne self-assigned this Nov 3, 2021
@taylorbourne taylorbourne merged commit 1e6334d into master Nov 4, 2021
@taylorbourne taylorbourne deleted the develop branch November 4, 2021 00:03
@tarkah
Copy link
Collaborator

tarkah commented Nov 9, 2021

Sorry, I was out on vacation for a few days. I'm not sure this is a good change for our end users.

I think lazystream should be responsible over defining an "override" to the default host. See tarkah/lazystream#86.

My thought is I'll also add a subcommand for lazystream called host which just outputs the configured host name. Then lazyStreamHost can be changed to hostOverride. We can then do something like the following pseudo-code:

override = if $hostOverride; then "-host-override $hostOverride"; else "";
export IP=$(getent ahostsv4 $(lazystream $override host) | awk '{ print $1 }' | head -1)

And same when calling lazystream in the cron script.

@tarkah tarkah mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants