-
-
Notifications
You must be signed in to change notification settings - Fork 525
docs: all features #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: all features #1786
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -301,9 +301,12 @@ | |
| //! for the crate to work. This feature was added in preparation of other ports like cef and servo. | ||
| //! - `protocol` (default): Enables [`WebViewBuilder::with_custom_protocol`] to define custom URL scheme for handling tasks like | ||
| //! loading assets. | ||
| //! - `x11` (default): Enables x11 support and dependencies on Linux. | ||
| //! - `serde`: Enables `dpi`'s `serde` feature. | ||
|
Legend-Master marked this conversation as resolved.
|
||
| //! - `devtools`: Enables devtools on release builds. Devtools are always enabled in debug builds. | ||
| //! On **macOS**, enabling devtools, requires calling private APIs so you should not enable this flag in release | ||
| //! build if your app needs to publish to App Store. | ||
| //! - `mac-proxy`: Enables `WebViewBuilder::with_proxy_config` on macOS. | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is from #1006, it's not super clear to me why we needed this in a feature flag for macOS? From the description in the original PR, it seems like it's only available on later version of macOS but I think that can be gated in a version check?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #1006 (comment) / https://github.com/tauri-apps/wry/pull/1006/changes#diff-182c0a218443303957d1585b15478976c27894b9104c8caa2527f41f357b7796 I think it could still be an issue nowadays after the objc2 migration because the whole framework was added in 10.14 while we still support 10.13 so i think it could cause build issues (not runtime issues after adding version checks) on 10.13
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will something you tried in #1781 work with this as well?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Or i'll try to get a 10.13 vm running again, which i need a bit of time for, and test how things go.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
But without the 0.7 annotation, this here would stay until we drop 10.13 support. |
||
| //! - `linux-body`: Enables body support of custom protocol request on Linux. Requires | ||
| //! WebKit2GTK v2.40 or above. | ||
| //! - `tracing`: enables [`tracing`] for `evaluate_script`, `ipc_handler`, and `custom_protocols`. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually wonder if we should remove this as well that nothing except the builder methods are still behind the flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there ever a reason for this?