docs: all features - #1786
Conversation
| //! Avoid this in release build if your app needs to publish to App Store. | ||
| //! - `fullscreen`: Fullscreen video and other media on **macOS** requires calling private functions. | ||
| //! Avoid this in release build if your app needs to publish to App Store. | ||
| //! - `mac-proxy`: Enables `WebViewBuilder::with_proxy_config` on macOS. |
There was a problem hiding this comment.
This is from #1006, it's not super clear to me why we needed this in a feature flag for macOS?
From the description in the original PR, it seems like it's only available on later version of macOS but I think that can be gated in a version check?
There was a problem hiding this comment.
#1006 (comment) / https://github.com/tauri-apps/wry/pull/1006/changes#diff-182c0a218443303957d1585b15478976c27894b9104c8caa2527f41f357b7796
I think it could still be an issue nowadays after the objc2 migration because the whole framework was added in 10.14 while we still support 10.13 so i think it could cause build issues (not runtime issues after adding version checks) on 10.13
There was a problem hiding this comment.
Will something you tried in #1781 work with this as well?
There was a problem hiding this comment.
I'm not sure, i don't think so because we do have to link the framework at least - at least if i look at objc2-generated it seems like it.
I think in this case we'd need #1776 - or we just drop support for compiling wry on 10.13, running apps should work regardless.
The fck, i forgot what my PR was. Yes it may work
Or i'll try to get a 10.13 vm running again, which i need a bit of time for, and test how things go.
There was a problem hiding this comment.
The fck, i forgot what my PR was. Yes it may work
But without the 0.7 annotation, this here would stay until we drop 10.13 support.
| @@ -301,9 +301,12 @@ | |||
| //! for the crate to work. This feature was added in preparation of other ports like cef and servo. | |||
| //! - `protocol` (default): Enables [`WebViewBuilder::with_custom_protocol`] to define custom URL scheme for handling tasks like | |||
There was a problem hiding this comment.
Actually wonder if we should remove this as well that nothing except the builder methods are still behind the flag
There was a problem hiding this comment.
Was there ever a reason for this?
Package Changes Through 15fc1edThere are 1 changes which include wry with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
2 participants
No description provided.