fix(linux): set suggested filename for download started handler - #1594
Merged
Conversation
Contributor
Package Changes Through da58369There are 1 changes which include wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
pewsheen
previously approved these changes
Aug 9, 2025
FabianLars
marked this pull request as ready for review
August 12, 2025 19:36
Member
Author
|
i forgot the results of my macos tests but will open another PR for that if there was anything to change. |
pewsheen
reviewed
Aug 13, 2025
pewsheen
approved these changes
Aug 13, 2025
This was referenced Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as a draft mainly cause i didn't check how macos behaves yet. the intention here (apart from making the download handler actually work on linux) was to make it match the behavior on windows which shows the standard behavior you know from browsers.
it's ready for review, i just don't want it to be merged yet.