Skip to content

feat: Add default download handler - #14006

Closed
FabianLars wants to merge 5 commits into
devfrom
feat/default-download
Closed

feat: Add default download handler#14006
FabianLars wants to merge 5 commits into
devfrom
feat/default-download

Conversation

@FabianLars

@FabianLars FabianLars commented Aug 14, 2025

Copy link
Copy Markdown
Member

I wonder if the is_local check is a bit too much? after all browsers download files from all websites as well 🤔

Together with tauri-apps/wry#1594 & tauri-apps/wry#1599 this now:
closes #13734
closes #4633

@FabianLars
FabianLars requested a review from a team as a code owner August 14, 2025 21:03
@github-actions

github-actions Bot commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through c1cf7ce

There are 10 changes which include tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-bundler with minor, tauri-macos-sign with minor, tauri-runtime-wry with minor, tauri with minor, @tauri-apps/api with minor, tauri-runtime with minor, tauri-plugin with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.7.0 2.8.0
tauri-utils 2.6.0 2.7.0
tauri-macos-sign 2.1.0 2.2.0
tauri-bundler 2.5.2 2.6.0
tauri-runtime 2.7.1 2.8.0
tauri-runtime-wry 2.7.2 2.8.0
tauri-codegen 2.3.1 2.3.2
tauri-macros 2.3.2 2.3.3
tauri-plugin 2.3.1 2.4.0
tauri-build 2.3.1 2.3.2
tauri 2.7.0 2.8.0
@tauri-apps/cli 2.7.1 2.8.0
tauri-cli 2.7.1 2.8.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars

Copy link
Copy Markdown
Member Author

I forgot to add a note about this on the builder methods. Will do that tomorrow (Friday)

@Legend-Master

Legend-Master commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

Should we enable this in wry by default instead? I feel like it doesn't quite make sense to block downloads by default anyways, and it is already the case for webview2

I wonder if the is_local check is a bit too much? after all browsers download files from all websites as well 🤔

Don't feel like we need to restrict that either

@FabianLars

Copy link
Copy Markdown
Member Author

Ah now that you mention it i meant to disable it by default on windows but forgot about it. Anyway, i don't care about the default so if you prefer that i'll change it in Wry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saving files from vanilla js code does nothing (but is working in modern browsers). [bug] Can not download in front end

2 participants