Remove AsRef<Window> on WebviewWindow - #14026
Conversation
Package Changes Through b625a55There are 10 changes which include tauri with minor, tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-bundler with minor, tauri-macos-sign with minor, tauri-runtime-wry with minor, tauri-runtime with minor, @tauri-apps/api with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
It's fine. I just looked up some resources and found that whether this is considered a breaking change is somewhat controversial: https://std-dev-guide.rust-lang.org/breaking-changes/new-trait-impls.html#inference-breaks-when-a-second-generic-impl-is-introduced. Personally, I wouldn't consider it a breaking change; otherwise, But since it does break plugins before |
|
Yeah, that's the problem, it is not a problem by itself but the way we have a single AsRef impl to begin with makes it a breaking change and the fact that it does affect the plugins usages right now |
This reverts the
AsRef<Window>impl forWebviewWindowmade in #14012cc @WSH032, after some discussion with the team, we think we should avoid this type of breaking changes in minors
And we can instead, add explicit methods like
as_window,as_webview