Skip to content

refactor: add type annotation on as_ref for upcoming tauri 2.8 - #2917

Closed
Legend-Master wants to merge 2 commits into
tauri-apps:v2from
Legend-Master:webview-window-as-ref-tauri-2.8
Closed

refactor: add type annotation on as_ref for upcoming tauri 2.8#2917
Legend-Master wants to merge 2 commits into
tauri-apps:v2from
Legend-Master:webview-window-as-ref-tauri-2.8

Conversation

@Legend-Master

Copy link
Copy Markdown
Contributor

In tauri-apps/tauri#14012 we added as_ref to support casting to a Window, and these plugins will no longer compile due to that

@Legend-Master
Legend-Master requested a review from a team as a code owner August 18, 2025 04:36
@github-actions

github-actions Bot commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through 6916d4b

There are 14 changes which include fs with patch, fs-js with patch, nfc with patch, nfc-js with patch, opener with minor, opener-js with minor, os with patch, os-js with patch, positioner with patch, positioner-js with patch, store with minor, store-js with minor, window-state with patch, window-state-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.32 2.0.33
api-example-js 2.0.28 2.0.29
fs 2.4.1 2.4.2
fs-js 2.4.1 2.4.2
dialog 2.3.2 2.3.3
dialog-js 2.3.2 2.3.3
opener 2.4.0 2.5.0
opener-js 2.4.0 2.5.0
http 2.5.1 2.5.2
http-js 2.5.1 2.5.2
nfc 2.3.0 2.3.1
nfc-js 2.3.0 2.3.1
os 2.3.0 2.3.1
os-js 2.3.0 2.3.1
persisted-scope 2.3.1 2.3.2
positioner 2.3.0 2.3.1
positioner-js 2.3.0 2.3.1
store 2.3.0 2.4.0
store-js 2.3.0 2.4.0
window-state 2.4.0 2.4.1
window-state-js 2.4.0 2.4.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master

Legend-Master commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

I think we should release this before we release tauri 2.8 so people will still get a good build when they run cargo update (or alternatively revert tauri-apps/tauri#14012 and delay it to v3)

@Legend-Master

Copy link
Copy Markdown
Contributor Author

Went for the revert: tauri-apps/tauri#14026

@Legend-Master
Legend-Master deleted the webview-window-as-ref-tauri-2.8 branch August 18, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant