refactor(android)!: rename lifecycle bindings by Legend-Master · Pull Request #1288 · tauri-apps/tao

Legend-Master · 2026-07-28T02:33:15Z

~~Waiting on #1209~~

github-actions · 2026-07-28T02:51:06Z

Package Changes Through `229ae4f`

There are 2 changes which include tao-macros with patch, tao with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package	current	next
tao-macros	0.1.3	0.1.4
tao	0.35.3	0.36.0

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

FabianLars · 2026-07-28T07:53:38Z

do we have a better name for https://github.com/Legend-Master/tao/blob/ca69bcc2fc310472beaf678701f7a72a1411ea62/src/platform_impl/android/ndk_glue.rs#L330 ? maybe a bit confusing to have onCreate and create. createApp or init?

Legend-Master · 2026-07-28T08:02:23Z

Ah, I sorta see why it was renamed to onActivityCreate now that create was kept in #1154, let me take a closer look at why are we having so many create functions, looking at wry's wryCreate, onCreate, create 😂

Legend-Master · 2026-07-28T09:26:14Z

Ok so basically wry is doing what tao is supposed to do on Android so it calls wryCreate for itself and also calls onCreate and create for tao. I'm still super confused about the differences between onCreate and create though that one is call inside WryActivity while the other is in WryLifecycleObserver attached in WryActivity.onCreate

FabianLars-crabnebula · 2026-07-28T09:33:57Z

I assume the idea was to have create be called as early as possible (to register the logger whatever as early as possible) but i agree that that doesn't make much sense here if it's also simply called in activity onCreate

Legend-Master · 2026-07-28T10:17:09Z

@FabianLars have you tried multi-window setup on Android before? The current code looks quite weird that create is called on every WryActivity.onCreate which calls the main function that maps to the tauri app's mobile entry point. Should this function be called only once?

FabianLars · 2026-07-28T10:21:20Z

+///       - `private external fun onResume(activity: WryActivity)`
+///       - `private external fun onPause(activity: WryActivity)`
+///       - `private external fun onStop(activity: WryActivity)`
+///       - `private external fun onSaveInstanceState(activity: WryActivity)`


this getting the activity but not the instance is a bit awkward imo. since we're not using this callback, maybe remove it and only add it when we actually need it so we know what input we actually need?

similar situation for onLowMemory which isn't used anywhere

this getting the activity but not the instance is a bit awkward imo.

Sorry what instance?

I honestly don't know why onSaveInstanceState is even here that there's no onRestoreInstanceState for it to be useful. Also it doesn't even pass in the bundle for you to store the data which made it completely useless. Maybe removing it?

similar situation for onLowMemory which isn't used anywhere

That one seems to go through to the event loop but we never mapped it to anything... I don't mind removing the activity here since it's not tied to the activity.

FabianLars · 2026-07-28T10:24:41Z

yes i tried it before merging lucas' prs. the changes were a bit too much to approve without testing. I did not notice any issues with the current code but i totally agree it's weird.

still trying to follow lucas' train of thought on why he added that lifecycle thing

Legend-Master · 2026-07-28T10:33:43Z

Also found that we're calling startActivity in tao that is required in wry which is also not documented...

FabianLars · 2026-07-28T10:45:44Z

And i just re-tested the multiwindow project, seems like i misunderstood how the lifecycle observer works. It looks like once set it uses the same observer instance across all activities, meaning the observer's onCreate is only called once, not on every activity onCreate. So Rust.create and wryCreate are indeed only called once.
(that's kinda what i hoped it does when i added the ndk-context but gave up on using the observer for that before really understanding it all)

Edit: This is true for all of the observer methods we have defined here. They are all called app-wide, not per-activity. I also tested the onpause hook for example when going to background while the main activity is not onscreen.

Edit2: This may be because of #1266 (comment) actually

Legend-Master · 2026-07-28T10:49:47Z

Thanks for testing, that really helped 😂 This is still super confusing I must say that ProcessLifecycleOwner.get().lifecycle.addObserver(WryLifecycleObserver) on the new activity doesn't trigger WryLifecycleObserver.onCreate?

Edit: I see, https://developer.android.com/reference/androidx/lifecycle/ProcessLifecycleOwner I though it was activity lifecycle owner

Legend-Master · 2026-07-28T10:51:56Z

Edit: This is true for all of the observer methods we have defined here. They are all called app-wide, not per-activity. I also tested the onpause hook for example when going to background while the main activity is not onscreen.

Which means all of them were wrong and should be fixed in tauri-apps/wry#1720 ?

FabianLars · 2026-07-28T10:59:51Z

This is still super confusing I must say that ProcessLifecycleOwner.get().lifecycle.addObserver(WryLifecycleObserver) on the new activity doesn't trigger WryLifecycleObserver.onCreate?

Yeah, that's the part i still don't get either. I don't see any docs saying that it gets ignored in any cases but i guess there's some "normal" java or android thing at play here that notices it's the same instance being added all the time idk. I'll stop thinking about this for now 😂

Which means all of them were wrong and should be fixed in tauri-apps/wry#1720 ?

Not sure what exactly you mean. The PR moves Resumed/Suspended from app-wide to per-activity == from Lifecycle to Activity which makes sense now. But i think i just don't get what you mean.

What's also fun is that the lifecycle onCreate fires after activity onCreate so this #1288 (comment) isn't actually the case (or may not be the case)

Legend-Master · 2026-07-28T11:10:36Z

Yeah, that's the part i still don't get either. I don't see any docs saying that it gets ignored in any cases but i guess there's some "normal" java or android thing at play here that notices it's the same instance being added all the time idk. I'll stop thinking about this for now 😂

The doc says

You can consider this LifecycleOwner as the composite of all of your Activities, except that Lifecycle.Event.ON_CREATE will be dispatched once
https://developer.android.com/reference/androidx/lifecycle/ProcessLifecycleOwner#:~:text=You%20can%20consider%20this%20LifecycleOwner%20as%20the%20composite%20of%20all%20of%20your%20Activities%2C%20except%20that%20Lifecycle.Event.ON_CREATE%20will%20be%20dispatched%20once

Not sure what exactly you mean. The PR moves Resumed/Suspended from app-wide to per-activity == from Lifecycle to Activity which makes sense now. But i think i just don't get what you mean.

right right right, that's correct since we didn't move the events yet

FabianLars · 2026-07-28T11:38:19Z

-///       - `private external fun onActivitySaveInstanceState()`
-///       - `private external fun onActivityDestroy(activity: WryActivity)`
-///       - `private external fun onActivityLowMemory()`
+///       - `private external fun onFirstActivityCreate(activity: WryActivity)`


we currently don't give it that in wry - we can i think because the lifecycle owner is the activity

if we were i'm thinking about moving the ndk-context thing into here but it sucks that it's called after the activity's onCreate

we currently don't give it that in wry - we can i think because the lifecycle owner is the activity

We do, it should be easier to see after tauri-apps/wry#1790

if we were i'm thinking about moving the ndk-context thing into here but it sucks that it's called after the activity's onCreate

I don't mind it but I'd probably keep it just for the timing, I could make a comment on the reasons if you want

No we don't: https://github.com/tauri-apps/wry/pull/1790/changes#diff-76280dd9be7cec50ab33d778adb7380d01ebfe63a7b5373ee637ef710fe60322R29 - i was talking about the function argument.

I don't mind it but I'd probably keep it just for the timing, I could make a comment on the reasons if you want

Talking about timing, i wonder if we even should use the lifecycle thing or if we just just call it in onActivity if there's a way to have a variable across all activities to check if it has been called already. The incorrect timing here really puts me off.

No we don't: https://github.com/tauri-apps/wry/pull/1790/changes#diff-76280dd9be7cec50ab33d778adb7380d01ebfe63a7b5373ee637ef710fe60322R29 - i was talking about the function argument.

Ah, I see, was testing it in tauri and it worked so didn't notice

Talking about timing, i wonder if we even should use the lifecycle thing or if we just just call it in onActivity if there's a way to have a variable across all activities to check if it has been called already. The incorrect timing here really puts me off.

Trying something like tauri-apps/wry@11dab6b but I really don't know what java land smokes that if this works. I would honestly say just leave this alone since it didn't cause any problems so far.

The timing is actually correct I think, we need to run the android entry point after we setup many things.

Trying something like tauri-apps/wry@11dab6b but I really don't know what java land smokes that if this works. I would honestly say just leave this alone since it didn't cause any problems so far.

That works in the multiwindow example i tested everything else at least

The timing is actually correct I think, we need to run the android entry point after we setup many things.

we're talking about https://github.com/tauri-apps/tao/blob/dev/src/platform_impl/android/ndk_glue.rs#L330 and https://github.com/tauri-apps/tao/blob/dev/src/platform_impl/android/ndk_glue.rs#L389 right? to me create looks like it wants to run first.

I almost want to merge these 2 callbacks, we could do the isFirstActivity check in there instead but i think i'm just going crazy - we can keep everything as is and focus on getting it released instead 😂

we're talking about https://github.com/tauri-apps/tao/blob/dev/src/platform_impl/android/ndk_glue.rs#L330 and https://github.com/tauri-apps/tao/blob/dev/src/platform_impl/android/ndk_glue.rs#L389 right? to me create looks like it wants to run first.

Yeah, it looks like so but it doesn't and it's probably correct (not semantically, functionally) 😂

I would honestly just leave it to another day, I have documented the timings for now.

FabianLars

can't test the last commit rn 🤷

Legend-Master · 2026-07-28T14:05:55Z

I tested or else I wouldn't know there's a tao-macros bug 😂

FabianLars · 2026-07-28T14:07:28Z

i assumed as much, i just like to document what i did in the approval, hence the (untested) comments you may have seen once or twice 😂

lucasfernog and others added 5 commits April 30, 2026 11:29

refactor(mobile): move Resumed and Suspended to WindowEvent

8c13a53

move events

f20bd58

Merge branch 'dev' into refactor/resumed-events

c1cd0f5

Merge branch 'dev' into refactor/resumed-events

9b2612e

refactor(android)!: rename lifecycle bindings

ca69bcc

Legend-Master changed the base branch from dev to refactor/resumed-events July 28, 2026 02:33

Legend-Master changed the title ~~Rename android life cycle bindings~~ refactor(android)!: rename lifecycle bindings Jul 28, 2026

Legend-Master mentioned this pull request Jul 28, 2026

refactor: changes for tao 0.36 lifecycle renames tauri-apps/wry#1790

Merged

Legend-Master added 2 commits July 28, 2026 16:00

Document onNewIntent

60433a7

Add change file

e0cbfa5

Legend-Master deleted the branch tauri-apps:dev July 28, 2026 09:49

Legend-Master closed this Jul 28, 2026

This comment was marked as resolved.

Sign in to view

Legend-Master reopened this Jul 28, 2026

Legend-Master changed the base branch from refactor/resumed-events to dev July 28, 2026 09:57

Merge branch 'dev' into rename-android-life-cycle-bindings

9f029ff

FabianLars reviewed Jul 28, 2026

View reviewed changes

Legend-Master added 2 commits July 28, 2026 18:43

onLowMemory does not need the activity

204358a

Remove onSaveInstanceState

4aad75e

Update change file

46634bb

Rename create to onFirstActivityCreate

008a011

Legend-Master marked this pull request as ready for review July 28, 2026 11:13

Legend-Master requested a review from a team as a code owner July 28, 2026 11:13

Legend-Master and others added 3 commits July 28, 2026 19:34

revert unrelated change

f9ddbe0

merge conflict

6781895

Merge branch 'dev' into rename-android-life-cycle-bindings

5280be1

FabianLars reviewed Jul 28, 2026

View reviewed changes

Legend-Master added 2 commits July 28, 2026 20:59

document main entry point runs after onCreate

1d21f26

onFirstActivityCreate don't take activity

229ae4f

FabianLars approved these changes Jul 28, 2026

View reviewed changes

Legend-Master merged commit 2b818c4 into tauri-apps:dev Jul 28, 2026
20 checks passed

Legend-Master deleted the rename-android-life-cycle-bindings branch July 28, 2026 14:06

github-actions Bot mentioned this pull request Jul 28, 2026

Publish New Versions #1229

Merged

Uh oh!

Uh oh!

Conversation

Legend-Master commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package Changes Through 229ae4f

Uh oh!

FabianLars commented Jul 28, 2026

Uh oh!

Legend-Master commented Jul 28, 2026

Uh oh!

Legend-Master commented Jul 28, 2026

Uh oh!

FabianLars-crabnebula commented Jul 28, 2026

Uh oh!

This comment was marked as resolved.

Legend-Master commented Jul 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FabianLars commented Jul 28, 2026

Uh oh!

Legend-Master commented Jul 28, 2026

Uh oh!

FabianLars commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Legend-Master commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Legend-Master commented Jul 28, 2026

Uh oh!

FabianLars commented Jul 28, 2026

Uh oh!

Legend-Master commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Legend-Master Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FabianLars left a comment

Choose a reason for hiding this comment

Uh oh!

Legend-Master commented Jul 28, 2026

Uh oh!

Uh oh!

FabianLars commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Legend-Master commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

Package Changes Through `229ae4f`

FabianLars commented Jul 28, 2026 •

edited

Loading

Legend-Master commented Jul 28, 2026 •

edited

Loading

Legend-Master commented Jul 28, 2026 •

edited

Loading

Legend-Master Jul 28, 2026 •

edited

Loading