Skip to content

refactor(mobile)!: move Resumed and Suspended to WindowEvent - #1209

Merged
Legend-Master merged 4 commits into
devfrom
refactor/resumed-events
Jul 28, 2026
Merged

refactor(mobile)!: move Resumed and Suspended to WindowEvent#1209
Legend-Master merged 4 commits into
devfrom
refactor/resumed-events

Conversation

@lucasfernog

Copy link
Copy Markdown
Member

follow up for tauri-apps/tauri#15199

@lucasfernog
lucasfernog requested a review from a team as a code owner April 30, 2026 14:31
@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Package Changes Through 9b2612e

There are 1 changes which include tao with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tao 0.35.3 0.36.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master Legend-Master left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android part looks good to me

/// - `private external fun resume()`
/// - `private external fun pause()`
/// - `private external fun stop()`
/// - `private external fun start(activity: WryActivity)`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming here is honestly so confusing, some are prefixed with onActivity while the others are not.

@Legend-Master Legend-Master added the type: breaking change This issue or pull request will introduce a breaking change and requires major version bump label Jul 23, 2026

@FabianLars FabianLars left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can support started and stopped on ios (with scenes at least) as well but that's something to investigate in another pr

ios side looks good (though i can't actually test it rn)

@Legend-Master Legend-Master changed the title refactor(mobile): move Resumed and Suspended to WindowEvent refactor(mobile)!: move Resumed and Suspended to WindowEvent Jul 28, 2026
@Legend-Master
Legend-Master merged commit 71b59ef into dev Jul 28, 2026
25 checks passed
@Legend-Master
Legend-Master deleted the refactor/resumed-events branch July 28, 2026 09:49
@github-actions github-actions Bot mentioned this pull request Jul 28, 2026
@Legend-Master
Legend-Master restored the refactor/resumed-events branch July 28, 2026 09:52
@Legend-Master
Legend-Master deleted the refactor/resumed-events branch July 28, 2026 09:53
@Legend-Master
Legend-Master restored the refactor/resumed-events branch July 28, 2026 09:56
@Legend-Master
Legend-Master deleted the refactor/resumed-events branch July 28, 2026 09:57
Legend-Master added a commit to tauri-apps/wry that referenced this pull request Jul 29, 2026
* chore: updates for tao 0.36

ref tauri-apps/tao#1209

* refactor: changes for tao 0.36 lifecycle renames (#1790)

* refactor: changes for tao 0.36 lifecycle renames

* Update

* Make it easier to see that `onCreate` runs first

* more docs

* Try to use an atomic bool instead of ProcessLifecycleOwner

* Revert "Try to use an atomic bool instead of ProcessLifecycleOwner"

This reverts commit 11dab6b.

* update tao

* update change file

* clean up

* Rename binding `wryCreate` to `onFirstActivityCreateWry`

* more docs

---------

Co-authored-by: Tony <68118705+Legend-Master@users.noreply.github.com>
Da-NKP pushed a commit to tactile-eng/tao that referenced this pull request Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: breaking change This issue or pull request will introduce a breaking change and requires major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants