fix(ios): catch simulator from platform value. - #471
Merged
Conversation
lucasfernog
approved these changes
Jul 31, 2025
Member
|
we've done something similar on tauri itself |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Xcode 16.3 appears to have changed the architecture name used for iOS Simulator builds, which causes the current detection logic to fail when identifying simulator targets.
Changes:
Updated the detection logic to analyze PLATFORM_DISPLAY_NAME instead of relying on architecture alone.
Preserved the previous logic to maintain compatibility with older Xcode versions.
This ensures robust simulator detection across both old and new Xcode releases.