test(cua-driver): prepare visible GTK3 controls before input - #7
Merged
tanishqkancharla merged 3 commits intoSep 11, 2026
Merged
tanishqkancharla merged 3 commits into
tanishqkancharla merged 3 commits into
Conversation
tanishqkancharla
changed the base branch from
codex/linux-screen-origin-certification
to
codex/linux-observation-visibility
September 11, 2026 05:08
tanishqkancharla
marked this pull request as ready for review
September 11, 2026 05:08
tanishqkancharla
merged commit Sep 11, 2026
e25f348
into
codex/linux-observation-visibility
43 of 45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visible GTK3 setup for canonical X11 tests
Canonical CI34558519742 at2e81b exposes hidden fixture assumptions after visible-only accessibility observations. The native GTK3 scroll traces visibly advance inner content (line03/line07), but scroll_offset is absent before and after because its label is below the default window viewport. Popover controls and exit are likewise below the viewport. The tests previously relied on offscreen accessibility nodes. The original failed results are preserved.
Scope: drive the owned X11 fixture into a usable visible state using public screen-size/window-frame actions before recording and before the background sentinel is established. Verify returned geometry independently and require the original controls/state markers in fresh observations. Apply only to affected scroll, popover and AX roster cases. Keep tested actions and original outcome assertions unchanged; missing scroll markers must be explicit setup/observation failures instead of defaulting to zero. No product visibility-filter changes, fixture mocks or hidden-state oracles.
Acceptance: rerun affected canonical rows with fresh visible controls and all existing outcome/focus/z-order/cursor/no-leaked-input oracles; preserve failures and recordings. X11 resizing does not certify Wayland, whose geometry protocol limitation remains explicit. Then recertify affected full lanes before readiness. This test-only draft stacks on the screen-origin candidate and is separate from the pixel-focus refusal product correction. Issues are disabled in this fork; this draft is the problem record.
Implementation: the shared test helper first observes required controls and returns without resizing when they are already present. Otherwise it reads the real screen size, makes one public exact-window resize request (800×1000 at20,20 on the canonical1920×1080 desktop), and independently polls
list_windowsfor matching PID/window and geometry within2pixels. Only observation is retried. Fresh accessibility state must then contain the original required markers. Geometry or visibility failure is a setup failure, not a skipped/passing scroll.The setup hook runs after owned launch and before behavior recording or background-sentinel establishment. Only scroll/popover catalog rows, the full AX roster case, and desktop-scope scroll use it. Existing tested actions, positive-offset assertions and background oracles remain unchanged. Missing desktop-scroll offset readings are explicit errors on X11; native Wayland retains its previous setup/marker behavior and receives no geometry mutation. The original560×720 app default is unchanged for all other rows.
Local verification: rustfmt and
git diff --checkpass. The Linux-gated integration targets were verified on remote Linux; no local macOS GUI testing was performed. No canonical failures have been relabeled.Focused CI34560340210 at exact4815d9030 passes all eight affected canonical rows. Independent artifact checks verify exact driver/workflow/test identities, unique expected cases, original oracle sets and retained nonempty videos. Native AX scroll markers move0→84, foreground pixel scroll0→161; background pixel scroll correctly refuses with all focus/z-order/cursor/no-leaked-input/fixture oracles. The original tests/actions are unchanged apart from visible setup and explicit missing-marker errors. Full release-lane results for the combined candidate follow below; no agent result was rewritten.
Full Linux release verification now passes on combined candidate403572f34dfbdc83b17bda7fe4c351060be32785, which includes the exact product/test changes from #5, #6 and #7 with source attribution. CI34561195062 passes all four jobs: shared83, native39, capture7 and canonical local installation. Independent inspection preserves every original case/expected behavior/oracle, verifies typed refusal codes, source/CI identities and finalized recording paths. All129canonical cases pass without skips. The release binary SHA256 is e65549f1a2d77d168581a2c2cc84585f90b51748a1cf85c2cf43bfca7a49ba85; installed identity/config and owned daemon/temp cleanup also pass.
Nine unchanged public-SDK cases then pass on that exact release binary in an isolated Linux desktop: four font edits, displaced Code replacement and four Calc/focus/dropdown checks. Saved files and owned cleanup were independently checked. This is supported X11 acceptance, not new Wayland/macOS GUI evidence or an agent parity score. A fresh matched Terra font pair on evaluator2d8879f is running separately. Its first OpenSky attempt passes in62.822seconds/10calls with full60/28pt, text and original font families preserved; native is pending. Prior failed agent outcomes remain retained. The user has explicitly authorized merging these fixes into this fork.