fix(cua-driver): preserve translated X11 screen coordinates - #5
Merged
tanishqkancharla merged 3 commits intoSep 11, 2026
Merged
tanishqkancharla merged 3 commits into
tanishqkancharla merged 3 commits into
Conversation
This was referenced Sep 11, 2026
tanishqkancharla
marked this pull request as ready for review
September 11, 2026 05:06
tanishqkancharla
merged commit Sep 11, 2026
bf38039
into
codex/linux-observation-visibility
43 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An indexed font-field click in maximized LibreOffice Impress could miss the field by17pixels. The field already reported Screen coordinates, but its near-zero outer frame made the driver add the X11 client offset a second time. Matched pixel controls reproduced the wrong-center failure and succeeded17pixels above.
The Linux adapter now compares each component's Screen−Window translation with the X11 client origin before applying a nonzero rebase. Matching coordinates retain their Screen bounds; missing or inconsistent evidence preserves the existing renderer behavior. GTK/Wayland reconstruction and public schemas are unchanged. The extra Window-extents read may add observation latency.
This draft stacks on #4. Exact source2e81b passed compilation/focused checks in OpenSky CI34552663384 and nine real public-SDK cases: four font-field edits, displaced Code replacement, indexed/scrolled Calc edits, wrong-window refusal and editable dropdown-title retention. Saved files and owned cleanup were independently verified. Unfocused setValue+Enter is not fixed.
The fresh matched Terra font pair on frozen evaluator81cdcee has two retained failures: OpenSky resized only one word per textbox; native resized all text but changed the original font families. Fingerprints match. No new agent parity result is claimed; previous20-task results remain separate.
Original canonical run34558519742 is terminal: all three platform builds/unit checks and all Windows desktop lanes pass. Linux shared passes; native/capture expose the fixture visibility and structured-refusal problems isolated in #7/#6. Those original failures remain retained.
Full Linux release verification now passes on combined candidate403572f34dfbdc83b17bda7fe4c351060be32785, which includes the exact product/test changes from #5, #6 and #7 with source attribution. CI34561195062 passes all four jobs: shared83, native39, capture7 and canonical local installation. Independent inspection preserves every original case/expected behavior/oracle, verifies typed refusal codes, source/CI identities and finalized recording paths. All129canonical cases pass without skips. The release binary SHA256 is e65549f1a2d77d168581a2c2cc84585f90b51748a1cf85c2cf43bfca7a49ba85; installed identity/config and owned daemon/temp cleanup also pass.
Nine unchanged public-SDK cases then pass on that exact release binary in an isolated Linux desktop: four font edits, displaced Code replacement and four Calc/focus/dropdown checks. Saved files and owned cleanup were independently checked. This is supported X11 acceptance, not new Wayland/macOS GUI evidence or an agent parity score. A fresh matched Terra font pair on evaluator2d8879f is running separately. Its first OpenSky attempt passes in62.822seconds/10calls with full60/28pt, text and original font families preserved; native is pending. Prior failed agent outcomes remain retained. The user has explicitly authorized merging these fixes into this fork.
Issues are disabled in this fork, so the draft carries the problem record. No RFC or external contribution adaptation is involved.