Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement afterDrag #114

Merged
merged 4 commits into from
Dec 17, 2024
Merged

feat: implement afterDrag #114

merged 4 commits into from
Dec 17, 2024

Conversation

leomelzer
Copy link
Contributor

Thanks for making react-movable @tajo, I've found it very enjoyable to work with!

We had a requirement which lead us to this old issue: #54

4 years later, this is my attempt to add support for afterDrag :)

Let me know if I missed something.

Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 15d8290

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-movable Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -59,6 +59,9 @@ const TableAuto: React.FC = () => {
);
setWidths(widths);
}}
afterDrag={() => {
setWidths([]);
}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demonstrate usage for cleanup.

elements: this.getChildren(),
oldIndex,
newIndex,
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Execute afterDrag after onChange, without further conditions.

@tajo tajo merged commit b245d4c into tajo:main Dec 17, 2024
2 checks passed
@tajo
Copy link
Owner

tajo commented Dec 17, 2024

Thanks, looks great!

@tajo tajo mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants