Add Support for API Gateways in GCP #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneskaya
reviewed
Apr 13, 2023
providers/gcp/gateway/gateway.go
Outdated
| return resources, err | ||
| } | ||
|
|
||
| RegionsLoop: |
There was a problem hiding this comment.
To keep the code consistent with the rest of the codebase, I'd like to ask you not to work with labels. In this case the continue keyword would be enough.
providers/gcp/gateway/gateway.go
Outdated
| fmt.Printf("%+v\n", apiGateway) | ||
|
|
||
| layout := "2006-01-02T15:04:05.999999999Z" | ||
| parsedCreatedTime, err := time.Parse(layout, apiGateway.CreateTime) |
There was a problem hiding this comment.
I think here you can just use time.RFC3339Nano instead of your own layout
providers/gcp/gateway/gateway.go
Outdated
| } | ||
|
|
||
| for _, apiGateway := range apiGateways.Gateways { | ||
| fmt.Printf("%+v\n", apiGateway) |
There was a problem hiding this comment.
If that's for debug purpose, please get rid of this
mlabouardy
force-pushed
the
feature/675-support-gcp-api-gateway
branch
from
c2b730b to
add89c6
Compare
|
@ShubhamPalriwala I've fixed your PR based on Enes feedback so I can include it in this week release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #675
Solution
Notes
Just like Redis support #709, this also has to query all the zones and does not work with the "global" tag. As of now, both of the methods are called separately hence the same regions call happen twice.
In the near future, a separate feature to just make 1 call and then use that in both the places saving up time as well as compute.
Checklist