Add Support for Redis in GCP #709
Conversation
ShubhamPalriwala
force-pushed
the
feature/673-support-gcp-redis
branch
from
473d19b to
0773214
Compare
|
Merged develop, and tested the functionality post it, works as expected! |
|
Merged develop, and tested the functionality post it, works as expected! (2) |
providers/gcp/redis/redis.go
Outdated
| return resources, nil | ||
| } | ||
|
|
||
| func listGCPRegions(projectId string, creds option.ClientOption) ([]string, error) { |
There was a problem hiding this comment.
We can move this function to utilities since it will be used in many services https://github.com/tailwarden/komiser/blob/master/utils/regions.go
There was a problem hiding this comment.
alright, will do in a while and ping you once done!
There was a problem hiding this comment.
hey, just went over quickly through the existing utils and we already have a function defined that returns a static array here:
Line 821 in d145cda
I was confused with the naming for the function I am supposed to migrate, should I do something like a fetchGCPRegionsInRealtime()?
There was a problem hiding this comment.
@mlabouardy just made the changes, PTAL
mlabouardy
force-pushed
the
feature/673-support-gcp-redis
branch
from
91439c4 to
7efa64e
Compare
There was a problem hiding this comment.
all good @ShubhamPalriwala
I'll open a discussion in Discord to discuss how to improve the performance :)
|
Yep, that'd be great, thanks! |
Problem
Add Support for Redis Instances across ALL zones in GCP
Closes #673
Pointers
Querying all the zones is taking a significant amount of time! Tried the goroutines way also but that also isnt helping! Open to any performance improvement ideas
Solution
PS: Force pushed as I ran
go mod tidyto remove extra deps I carried during devChecklist