Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable export to PDF and copying of attachments #11

Merged
merged 24 commits into from
Jul 14, 2022
Merged

Enable export to PDF and copying of attachments #11

merged 24 commits into from
Jul 14, 2022

Conversation

tagatac
Copy link
Owner

@tagatac tagatac commented Jul 14, 2022

Use wkhtmltopdf for PDF support because it has the easiest emoji solution (via twemoji).

heic2jpg.go is untested as it is largely copied from upstream, and I have a PR open to create an interface upstream: adrium/goheif#2

goheif also has issues vendoring because there is no Go code in some of the required C++ subdirectories: golang/go#26366. This should also be fixed upstream, but as a stopgap, we need to use the cp and chmod commands (vendor makefile target).

Closes #4
Closes #5
Closes #7

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #11 (60672cc) into main (336899a) will increase coverage by 1.62%.
The diff coverage is 91.85%.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   90.44%   92.07%   +1.62%     
==========================================
  Files           3        4       +1     
  Lines         314      530     +216     
==========================================
+ Hits          284      488     +204     
- Misses         28       37       +9     
- Partials        2        5       +3     
Impacted Files Coverage Δ
opsys/outfile.go 88.00% <88.00%> (ø)
chatdb/chatdb.go 98.29% <92.68%> (-1.71%) ⬇️
main.go 85.00% <93.39%> (+9.59%) ⬆️
opsys/opsys.go 96.96% <93.75%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336899a...60672cc. Read the comment docs.

@tagatac tagatac merged commit c80a20b into main Jul 14, 2022
@tagatac tagatac deleted the pdf branch July 14, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant