Move heic2jpg functionality into an exported mockable interface #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set up Travis CI and Codecov for build and coverage statuses.
tagatac
added a commit
to tagatac/bagoup
that referenced
this pull request
Jul 14, 2022
Use wkhtmltopdf for PDF support because it has the easiest emoji solution (via twemoji). heic2jpg.go is untested as it is largely copied from upstream, and I have a PR open to create an interface upstream: adrium/goheif#2 goheif also has issues vendoring because there is no Go code in some of the required C++ subdirectories: golang/go#26366. This should also be fixed upstream, but as a stopgap, we need to use the cp and chmod commands (vendor makefile target). * Enable output to PDF * Add support or jpegs in PDFs * Switch to wkhtmltopdf for emoji support * Implement copying attachments * Convert HEIC attachments to JPEG for PDF output * Update example to match new defaults * Add "attached" text to attachment references in outfiles * Update dependencies * Install wkhtmltopdf in Travis CI * Use xvfb in Travis CI
|
These improvements and more can now be found in https://github.com/tagatac/goheif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move a common usage of this library behind an exported interface, so that the example usage is reduced from 85 lines to 13 lines.
Also:
Closes #1