-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: new folder structure #934
Conversation
🦋 Changeset detectedLatest commit: 0f503de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-folder-structure-t3-oss.vercel.app/ |
A new create-t3-app prerelease is available for testing. You can install this latest build in your project with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do a thorough review later but noticed this while glancing over it
Love this My bad on the old comment for the private procedure, rewrite: /**
* Protected (authed) procedure
*
* If you want a query or mutation to ONLY be accessible to logged in users, use
* this. It verifies the session is valid and guarantees ctx.session.user is not
* null
*
* @see https://trpc.io/docs/procedures
*/
export const protectedProcedure = t.procedure.use(enforceUserIsAuthed);
|
I posted this reply on theo's repo early today and just noticed this pull request on the ct3a repo. Just an observation based on my own experience modifying the t3 folder structure
|
Purely out of curiosity, when do you think this proposal might land in main, if at all? |
Might push it out during the holidays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHIPPPPPPPPPPPP
Ref: t3dotgg/rewire-t3-app#2
also restructured internally so the adding are now structured like a mirror of the generated project, instead of being grouped all in one per dep
TODO: Edit https://create.t3.gg/en/folder-structure