docs: made themeToggleButton a toggle button #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muradbu
requested review from
juliusmarminge,
nexxeln,
t3dotgg and
c-ehrlich
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
📚 documentation
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-fork-muradbuyukasik-next-t3-oss.vercel.app/ |
devvianto605
pushed a commit
to devvianto605/create-devviantex-nextjs-app
that referenced
this pull request
Jun 9, 2024
* docs: made themeToggleButton a toggle button * fix: more clear function name Co-authored-by: Shoubhit Dash <[email protected]> Co-authored-by: Julius Marminge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #781
✅ Checklist
Changelog
Refactored themeToggleButton to use a
<button>root element instead of 2 radio buttons so that the light/dark theme gets toggled regardless of where the user presses within the component.The component's
title,valueandaria-labelattributes gets set on page-load using the appropriate dark/light state.Screenshots
💯