feat: AuthShowcase only makes query when logged in #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
🦋 Changeset detectedLatest commit: b968636 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
📌 area: cli
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://create-t3-app-git-no-auth-errors-t3-oss.vercel.app/ |
c-ehrlich
requested review from
juliusmarminge,
nexxeln and
t3dotgg
as code owners
c-ehrlich
changed the title
juliusmarminge
approved these changes
Nov 2, 2022
Co-authored-by: Julius Marminge <[email protected]>
Co-authored-by: Julius Marminge <[email protected]>
devvianto605
pushed a commit
to devvianto605/create-devviantex-nextjs-app-deprecated
that referenced
this pull request
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Changelog
A lot of people seem to be confused that there are tRPC errors in the console as soon as they open their app
Example (there have been a bunch of these): https://discord.com/channels/966627436387266600/1020552951116333217/threads/1030282705734226051
This avoids those errors by only enabling the query if there is a user. As a nice benefit it also acts as builtin documentation for passing
undefinedfor the input and using theenabledoption.Screenshots
(taken after starting the dev server and navigating to localhost:3000 without being logged in)
Before:
After:
💯