Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table content active link not showing properly #674

Merged
merged 5 commits into from
Nov 3, 2022
Merged

fix: table content active link not showing properly #674

merged 5 commits into from
Nov 3, 2022

Conversation

ParasSolanki
Copy link
Contributor

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

In the create t3 app docs website the table of contents active link was not showing properly as you can see in first video.
Fixed that issue in second video.
Open for any feedback and improvements.

Screenshots

Not working example video
table-content-active-link-not-showing-properly.webm

Working video demo
working-active-link-of-table-contents.webm

💯

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 29fa268

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 1:56PM (UTC)

@github-actions github-actions bot added the 📚 documentation Improvements or additions to documentation label Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 98
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-881fi3o7e-t3-oss.vercel.app/

@juliusmarminge
Copy link
Member

Astro's formatting tools in editors are a bit hit and miss, please run pnpm format to make sure they are formatted correctly.

@juliusmarminge
Copy link
Member

Seems to not quite catch the Useful Resources table though but who cares, it's waaay better than before :)

https://create-t3-881fi3o7e-t3-oss.vercel.app/en/usage/prisma

CleanShot 2022-11-03 at 15 01 53@2x

@juliusmarminge juliusmarminge merged commit 70f2ff6 into t3-oss:next Nov 3, 2022
@ParasSolanki
Copy link
Contributor Author

ParasSolanki commented Nov 3, 2022 •
edited
Loading

Yeah if the last content is big enough then and can reach at the top then it will get highlighted.

image

@juliusmarminge
Copy link
Member

Yes i was just thinking if i see one header that should be the one which is highlighted but thats really not so dont mind me on that one

@ParasSolanki
Copy link
Contributor Author

looks like on my PC its working maybe your PC resolution is big

image

@juliusmarminge
Copy link
Member

looks like on my PC its working maybe your PC resolution is big

image

MBP14 with More Space

@ParasSolanki
Copy link
Contributor Author

ParasSolanki commented Nov 3, 2022 •
edited
Loading

Mine has normal HD resolution (Lenovo) laptop.

@juliusmarminge
Copy link
Member

Yeah the header is just down at the bottom for me xd

https://share.cleanshot.com/swETEq

@ParasSolanki ParasSolanki deleted the fix-table-content-active-link branch November 23, 2022 12:59
devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@ParasSolanki
fix: table content active link not showing properly (t3-oss#674)
648d936 
* fix: table content active link not showing properly

* chore: toc-heading condition getting twice

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-ehrlich c-ehrlich c-ehrlich left review comments

@juliusmarminge juliusmarminge juliusmarminge approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📚 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ParasSolanki @juliusmarminge @c-ehrlich