Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update to next13 #657

Merged
merged 10 commits into from
Oct 29, 2022
Merged

fix: update to next13 #657

merged 10 commits into from
Oct 29, 2022

Conversation

juliusmarminge
Copy link
Member

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

NOTE: This does not enable the appDir and all the fancy RSC stuff.

Screenshots

[Screenshots]

💯

@vercel
Copy link

vercel bot commented Oct 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
create-t3-app ⬜️ Ignored (Inspect) Oct 29, 2022 at 8:26AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 1845d0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App labels Oct 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 98
🟢 Best practices 93
🟠 SEO 86
🟠 PWA 54

Lighthouse ran on https://create-t3-app-git-julius-next13-t3-oss.vercel.app/

@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022 •
edited
Loading

A new create-t3-app prerelease is available for testing. You can install this latest build in your project with:

npx [email protected]

@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 26, 2022
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 27, 2022
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 27, 2022
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 27, 2022
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 27, 2022
@juliusmarminge juliusmarminge added the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 27, 2022
@github-actions github-actions bot removed the 🚀 autorelease add this label to a pr to trigger a beta release label Oct 27, 2022
@juliusmarminge juliusmarminge mentioned this pull request Oct 28, 2022
Closed
c-ehrlich
c-ehrlich requested changes Oct 29, 2022
View reviewed changes
Copy link
Member

@c-ehrlich c-ehrlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me other than the missing legacy peer deps in npmrc. Add that and lets ship it :) I also tested vercel deployment, everything working as expected 🔥

@juliusmarminge juliusmarminge enabled auto-merge (squash) October 29, 2022 08:26
@juliusmarminge juliusmarminge merged commit f1673eb into next Oct 29, 2022
@juliusmarminge juliusmarminge deleted the julius/next13 branch October 29, 2022 08:27
@github-actions github-actions bot mentioned this pull request Oct 29, 2022
Merged
@nimeshvaghasiya
Copy link

@juliusmarminge NOTE: This does not enable the appDir and all the fancy RSC stuff.
Is there any prerelease which use appDir and RSC?

@nexxeln
Copy link
Member

nexxeln commented Nov 10, 2022

@juliusmarminge NOTE: This does not enable the appDir and all the fancy RSC stuff. Is there any prerelease which use appDir and RSC?

You can use the experimental stuff. But tRPC won't work in it. There's some experimental stuff around tRPC in RSCs. You can take a look here

devvianto605 pushed a commit to devvianto605/create-devviantex-nextjs-app-deprecated that referenced this pull request Jun 9, 2024
@juliusmarminge @c-ehrlich
fix: update to next13 (t3-oss#657)
38aca71 
* update some stuff

* prettier

* apply some install flags

* properly apply flags

* formatting

* refactor

* fix flags

* Update cli/template/addons/next-auth/_npmrc

Co-authored-by: Julius Marminge <[email protected]>

* Create fluffy-masks-explain.md

Co-authored-by: Christopher Ehrlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-ehrlich c-ehrlich c-ehrlich approved these changes

@nexxeln nexxeln Awaiting requested review from nexxeln

@t3dotgg t3dotgg Awaiting requested review from t3dotgg

Assignees
No one assigned
Labels
📌 area: cli Relates to the CLI 📌 area: t3-app Relates to the generated T3 App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliusmarminge @nimeshvaghasiya @nexxeln @c-ehrlich